Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-140096] Genfill Marquee images are blinking during auto play and on click as well in Firefox browser #144

Merged
merged 18 commits into from
Dec 14, 2023

Conversation

drashti1712
Copy link
Collaborator

Copy link

aem-code-sync bot commented Dec 12, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link

aem-code-sync bot commented Dec 12, 2023

Page Scores Audits Google
/drafts/drashti/MWPW-137345/genfill-container?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ad3c16c) 88.28% compared to head (2617356) 89.83%.

Files Patch % Lines
...ativecloud/features/genfill/genfill-interactive.js 95.60% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   88.28%   89.83%   +1.55%     
==========================================
  Files           8        8              
  Lines         657      679      +22     
==========================================
+ Hits          580      610      +30     
+ Misses         77       69       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Drashti Modasara added 2 commits December 13, 2023 11:39
@Anupamasonnalagi
Copy link

@drashti1712 drashti1712 merged commit 225a647 into adobecom:main Dec 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants