Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MWPW-137345] Genfill Interactive Marquee #134

Merged
merged 1 commit into from
Dec 5, 2023
Merged

[MWPW-137345] Genfill Interactive Marquee #134

merged 1 commit into from
Dec 5, 2023

Conversation

drashti1712
Copy link
Collaborator

@drashti1712 drashti1712 commented Dec 5, 2023 •
edited by aishwaryamathuria
Loading

  • Implementation of the Genfill Interactive Marquee
  • Supports multiple viewports subject image set
  • Supports autoplay on page load and click intervention
  • Control for autoplay timers
  • Supported with interactive marquee with specs similar to standard large marquee

Resolves: MWPW-137345

Test URLs:

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 5, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@drashti1712 drashti1712 requested review from aishwaryamathuria, Ruchika4 and salonijain3 and removed request for aishwaryamathuria and Ruchika4 December 5, 2023 10:35
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 5, 2023 •
edited
Loading

Page Scores Audits Google
/drafts/drashti/MWPW-137345/genfill-container?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@salonijain3 salonijain3 merged commit 6d6585d into adobecom:main Dec 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salonijain3 salonijain3 salonijain3 approved these changes

@aishwaryamathuria aishwaryamathuria aishwaryamathuria approved these changes

@Ruchika4 Ruchika4 Awaiting requested review from Ruchika4

@suhjainadobe suhjainadobe Awaiting requested review from suhjainadobe

Assignees
No one assigned
Labels
needs verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashti1712 @salonijain3 @aishwaryamathuria