Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stage] MWPW-140084 - Margin is not proper and 'See it in action' and arrow are overlapped for GenFill Marquee for RTL locales #133

Merged
merged 8 commits into from
Dec 5, 2023

Conversation

drashti1712
Copy link
Collaborator

Copy link

aem-code-sync bot commented Dec 5, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link

aem-code-sync bot commented Dec 5, 2023

Page Scores Audits Google
/drafts/drashti/MWPW-137345/final-genfill/genfill-container3?martech=off Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (524b2ce) 90.29% compared to head (75654df) 90.29%.
Report is 1 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #133   +/-   ##
=======================================
  Coverage   90.29%   90.29%           
=======================================
  Files           5        5           
  Lines         546      546           
=======================================
  Hits          493      493           
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Anupamasonnalagi
Copy link

Verified the issue. 1. Right margin of the marquee is having proper spacing after localization. 2. Arrow and 'see it in action' text are not overlapping now. 3. Pointer is appearing on genfill image hover.
image (21)

@aishwaryamathuria aishwaryamathuria merged commit c7ebc3b into stage Dec 5, 2023
4 of 5 checks passed
@aishwaryamathuria aishwaryamathuria deleted the stage-genfill branch February 6, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants