fix(MWPW-158561): adds aria-label to search icon #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core Web Vitals Metrics
Recorded at: 2024-12-10T18:24:25.402Z |
Core Web Vitals Metrics
Recorded at: 2024-12-10T18:25:21.018Z |
Core Web Vitals Metrics
Recorded at: 2024-12-17T20:16:21.416Z |
sanrai
approved these changes
Dec 17, 2024
sanrai
requested changes
Dec 17, 2024
sanrai
approved these changes
Dec 18, 2024
Core Web Vitals Metrics
Recorded at: 2024-12-19T02:26:03.305Z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriiption:
As requested by accessibility team this PR adds the aria-label attribute to search icon
Resolves:
https://jira.corp.adobe.com/browse/MWPW-158561
Before:
<button data-testid="search-icon" type="button" class="consonant-SearchIco" tabindex="0" daa-ll="Search-24--Enter a key value pa"><span></span></button>After:
<button data-testid="search-icon" aria-label="Search" type="button" class="consonant-SearchIco" tabindex="0" daa-ll="Search-24--Enter a key value pa"><span></span></button>