Merge pull request #203 from adobecom/force-integration-tests

feat(MWPW-162743): enforce e2e tests for new components via GitHub action

.github/workflows/pull-request.yaml

@@ -5,6 +5,22 @@ on: [pull_request]
 permissions: write-all
 
 jobs:
+  check-test-requirements:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 16.13.1    # No cache line
+      - name: Install dependencies  # Added explicit install step
+        run: npm install @actions/core @actions/github
+      - name: Check PR Type and Tests
+        uses: actions/github-script@v6
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            const script = require('./test-enforcement.js')
+            await script({github, context, core})
   check-linting:
     runs-on: ubuntu-latest
     steps:

test-enforcement.js

@@ -0,0 +1,46 @@
+const enforceTestRequirements = async ({ github, context, core }) => {
+    try {
+        const { data: files } = await github.rest.pulls.listFiles({
+            owner: context.repo.owner,
+            repo: context.repo.repo,
+            pull_number: context.issue.number,
+        });
+
+        const prTitle = context.payload.pull_request.title;
+        const commitType = prTitle.split(':')[0].toLowerCase();
+
+        // Add debug logs
+        core.info(`PR Title: ${prTitle}`);
+        core.info(`Commit Type: ${commitType}`);
+        core.info(`Files changed: ${JSON.stringify(files.map(f => f.filename))}`);
+
+        const hasNewComponent = files.some(f => {
+            const isComponent = f.filename.includes('/components/');
+            const isNew = f.status === 'added';
+            // Add debug logs
+            core.info(`Checking file: ${f.filename}`);
+            core.info(`Is component? ${isComponent}`);
+            core.info(`Is new? ${isNew}`);
+            return isComponent && isNew;
+        });
+
+        const hasIntegrationTest = files.some(f =>
+            f.filename.includes('.e2e.js'),
+        );
+
+        // Add debug logs
+        core.info(`Has new component? ${hasNewComponent}`);
+        core.info(`Has integration test? ${hasIntegrationTest}`);
+
+        if (commitType === 'feat' && hasNewComponent && !hasIntegrationTest) {
+            core.setFailed('New feature components require integration tests');
+            return;
+        }
+
+        core.info('Test requirements check passed');
+    } catch (error) {
+        core.setFailed(error.message);
+    }
+};
+
+module.exports = enforceTestRequirements;