Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding essa schemas #863

Merged
merged 3 commits into from
Apr 21, 2020
Merged

adding essa schemas #863

merged 3 commits into from
Apr 21, 2020

Conversation

prabhum2
Copy link
Contributor

Please link to the issue #…

"description": "Name of the user who created this record",
"type": "string"
},
"xdm:createdDate": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the created and modify date that all other schemas use - https://github.com/adobe/xdm/blob/master/schemas/external/repo/common.schema.json#L32

"you may not use this file except in compliance with the License. You may obtain a copy",
"of the License at https://creativecommons.org/licenses/by/4.0/"
],
"$id": "https://ns.adobe.com/xdm/common/external-source-system-audit",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different the existing common/auditable schema - https://github.com/adobe/xdm/blob/master/schemas/common/auditable.schema.json

Are we saying everything in the common/auditable is "internal" audit fields? If I include both of these, am I going to be confused when I see both a xdm:createdDate and a repo:createdDate? Should these fields be named something like xdm:externalCreatedDate? These are just some questions I have.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned this specific mixin will be used as a reference to capture the auditable properties of customers data sets. We have CRM system and other Marketo needs to capture and present when was a record got created Vs Modified and by whom. common/auditable are the fields used meant to be used internally by the AEP services.

Copy link
Collaborator

@khanna-vikas khanna-vikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prabhum2 prabhum2 merged commit 62df618 into master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants