-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 419 - changing Identity id from URI format to plain string #420
Conversation
@chrisdegroot, @cmathis, @jwen-adobe, @cluby-adobe, @saurabhere, @gabebarcelos-adobe this is a proposed breaking change to the |
@kstreeter This looks good from tooling perspective based on my test. |
Technically this PR does remove the need for URIs, but the examples still are URIs. What is the reason we are not using URL encoding? The cases where there are non URL safe characters is a corner case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks clear and addresses the requirements as i understand them.
Looks good. So, |
Can this also include similar changes in the |
@saurabhere this change is limited to the Identity schema. The standard in XDM is to use @id for the globally unique identifier of all entities. |
@fmeschbe - we need to include this in the July 16th milestone. |
@@ -0,0 +1,6 @@ | |||
{ | |||
"xdm:id": "ISBN13#978-0765382030", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we really use an ISBN example where ISBN is already properly covered with an official URN namespace ?
In addition, the xdm:id
field is identifyig consumers as per the description, where an ISBN is not exactly a consumer ;-)
@@ -1,10 +1,16 @@ | |||
{ | |||
"xdm:identities": [ | |||
{ | |||
"@id": "https://data.adobe.io/entities/identity/id123", | |||
"xdm:id": "https://data.adobe.io/entities/identity/id123", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example, while not exactly wrong, does not seem to reflect the intent of this PR.
This PR is to address issue #419, where the definition of
@id
in theIdentity
schema is too constrained for real usage. This PR changes the field from@id
toxdm:id
, and updates all of the examples.