Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#364 - Video Analytics additions for ExperienceEvent - June 29th Milestone #417

Merged
merged 53 commits into from
Jul 14, 2018

Conversation

cdegroot-adobe
Copy link
Contributor

Issue #364
What are the schemas that are affected by the issue
/context/experienceevent.schema.json

What are examples of products that are impacted by the issue
Video Analytics
Video Ads
Media marketing in Target

Schema count is now 208
@cdegroot-adobe cdegroot-adobe changed the title Issue#364 - Video Analytics additions for ExperienceEvent Issue#364 - Video Analytics additions for ExperienceEvent - June 29th Milestone Jun 20, 2018
@cdegroot-adobe
Copy link
Contributor Author

@kstreeter @fmeschbe - Please note that we are targeting these schemas for use in the next few weeks, so need to make every attempt to get them in the June 29th milestone.

Copy link
Collaborator

@kstreeter kstreeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cdegroot-adobe, I did a first pass on this. The primary thing I think we need to work through is the nomenclature around "media", "asset", and in some places "content". Clearly "asset" already means something in XDM, and we should avoid using that word for anything that doesn't align with its pre-existing usage.

I would suggest we try to organize our terminology around something like this:

  • Asset - technical information about the video/image/etc. like size, encoding, etc. Note this probably does not include its location, since the location used for delivery (ie the CDN) is independent of where it might be stored in a CMS or repository.
  • Title - title information like series titles, episode information, etc. This may also include external identifiers for 3rd-party title registrars (like GraceNote, EIDR)
  • Media Playback - details about the playback session, like where it was actually delivered from, how long, etc. This would probably also include the CMS ID (lets call it CMS ID, not "Content ID"!)

"definitions": {
"adBreak": {
"properties": {
"@id": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be format URI, or else be an xdm:id

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved, thanks, also updated examples.

},
"xdm:podOffset": {
"title": "Ad Break Offset",
"type": "integer",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we double check that this can't be a fractional second, and thus a number?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this is always a whole number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, checked. Resolved.

"type": "string",
"description": "Program/Series Name."
},
"xdm:assetID": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to reconcile the terminology between "asset ID" and "content ID" in this schema. In our content repository model, the items have an "assetID". But here we seem to be saying that the CMS ID is called a "Content ID".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cosminci @gabebarcelos-adobe do we want to move to use s/content/asset/ in the schema names and identity here?

Copy link

@cosminci cosminci Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Media Analytics, the assetID is reported through custom metadata, and will not be available in the majority of timed media experience events.
We could update the properties (name / title / description) to be more consistent with the existing schemas.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdegroot-adobe @kstreeter - I'm not sure I follow. Are you suggesting adding an existing schema like Video or Image as a sub-schema to these and moving the appropriate attributes under those? Or are we discussing more of nomenclature of the existing schema?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gabebarcelos-adobe, I am not actually suggesting we include existing schemas directly, since we don't actually have most of the properties of an asset item in these schema. So it is just nomenclature. The use of the term "asset" in these schemas is describing a very different concept than it does in the XDM asset schemas. Also, the use of the term isn't completely consistent within the new schemas themselves, with multiple concepts all being called "asset".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a number of discussion @kstreeter is more comfortable with the usage of "asset" in this PR. He is also understanding that the Creative Cloud teams are also not having concerns with the usage from their reviews.

Issue considered closed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to re-open it. I am OK calling it asset, but it can't be assetID, as that is already used in the asset schema. It needs a different/unique name unless you are using it the same way - then it's OK.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One possibility is to use Iptc4xmpExt:Identifier

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right solution seemed to be to move to the IPTC Series structure. This gave me a way to resolve showName and assetID in a consistent way.
"iptc4xmpExt:Series": {
"iptc4xmpExt:Name": "nba_highlights",
"iptc4xmpExt:Identifier": "http://espn.com/series-identifiers/2613953",
},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

"VOD": "Video-on-Demand",
"Live": "Live Streaming",
"Linear": "Linear playback of the media asset",
"UGG": "User-generated Content",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UG "C" or UG "G"?

"type": "string",
"description": "Identifier of the ad asset."
},
"xdm:name": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be dc:title?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected - done

"type": "string",
"description": "The friendly (human-readable) name of the ad asset."
},
"xdm:duration": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be xmpDM:duration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ogoldman
Copy link
Collaborator

It looks to me like we should make a sweep through this entire PR and update all properties that are defined in XMP vocabs to leverage the same. Many of the properties here appear to have definitions in the XMP Dynamic Media namespace--which shouldn't be a surprise! For reference, see https://wwwimages2.adobe.com/content/dam/acom/en/devnet/xmp/pdfs/XMP%20SDK%20Release%20cc-2016-08/XMPSpecificationPart2.pdf

Copy link
Collaborator

@lrosenthol lrosenthol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are numerous problems that need to be correct with this PR, including some clear misunderstandings about how to model data in XDM and lack of usage of existing standards in the industry.

"type": "string",
"description": "Identifier of the ad break."
},
"xdm:podName": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why podName and not just name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to dc:title, github seems to have an issues as I am looking at this and not showing the change. It is definitely in the source files.

"type": "string",
"description": "The friendly name of the ad break."
},
"xdm:podOffset": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, why podOffset and not just offset?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to xdm:offset, github seems to have an issues as I am looking at this and not showing the change. It is definitely in the source files.

"@id": {
"title": "Ad ID",
"type": "string",
"description": "Identifier of the ad asset."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a unique ID? Is it related to the AdID standard? Please clarify

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ad ID is provided by Media Analytics customers when they track ads. It might be an internal ID from their CMS system, it might be from their ad provider (e.g. Freewheel) - there is no standardisation around this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then please clarify that in the description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved - Closed

"type": "string",
"description": "The name of the player responsible for rendering the ad."
},
"xdm:podPosition": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, why pod?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"xdm:podPosition": {
"title": "Ad Position in Pod",
"type": "integer",
"description": "The position (index) of the ad inside the parent ad break. The first ad has index 0, the second 1, and so on."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be index instead of position then? Position seems the wrong term

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"meta:extends": [
"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "Describes the duration in which the playback was stalled during playback.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after seeing different schemas that only differ slightly, they should all be a single schema with different values and not separate schemas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pattern that @trieloff introduced a while ago and is intended to provide the option to add additional metadata about the metrics so that design tools and automated processors can have more intelligence about the specifics of each metric.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

"meta:extends": [
"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "The number of stall states that occurred during a playback session.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after seeing different schemas that only differ slightly, they should all be a single schema with different values and not separate schemas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see response to schemas/data/stall-time.schema.json on the same comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

"meta:extends": [
"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "Describes the amount of time spent by a user on a specific timed media asset.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after seeing different schemas that only differ slightly, they should all be a single schema with different values and not separate schemas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see response to schemas/data/stall-time.schema.json on the same comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

"meta:extends": [
"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "Describes the duration passed between video load and start.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after seeing different schemas that only differ slightly, they should all be a single schema with different values and not separate schemas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see response to schemas/data/stall-time.schema.json on the same comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "Describes the total amount of time spent by a user on a specific timed media asset, which includes time spent watching ads.",
"definitions": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after seeing different schemas that only differ slightly, they should all be a single schema with different values and not separate schemas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see response to schemas/data/stall-time.schema.json on the same comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Copy link
Contributor Author

@cdegroot-adobe cdegroot-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to resolve the ITPC questions asap please.

},
"xdm:clicks": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
"description": "Click(s) actions on an advertisement."
},
"xdm:conversions": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, this is how we implement metrics across all the schemas in XC.

},
"xdm:conversions": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
"description": "A pre-defined action on a website triggered a conversion event to be fired"
"description": "A costumer pre-defined action(s) which triggers an event for performance evaluation."
},
"xdm:firstQuartiles": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, this is how we implement metrics across all the schemas in XC.

},
"xdm:firstQuartiles": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
"description": "A digital video ad has played through 25% of it's duration at normal speed."
"description": "A digital video ad has played through 25% of its duration at normal speed."
},
"xdm:impressions": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, this is how we implement metrics across all the schemas in XC.

},
"xdm:firstQuartiles": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
"description": "A digital video ad has played through 25% of it's duration at normal speed."
"description": "A digital video ad has played through 25% of its duration at normal speed."
},
"xdm:impressions": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
"description": "Impression(s) of an advertisement to an end user with the potential of being viewed."
},
"xdm:midpoints": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, this is how we implement metrics across all the schemas in XC.

},
"xdm:impressions": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
"description": "Impression(s) of an advertisement to an end user with the potential of being viewed."
},
"xdm:midpoints": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
"description": "A digital video ad has played through 50% of it's duration at normal speed."
"description": "A digital video ad has played through 50% of its duration at normal speed."
},
"xdm:starts": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
"description": "A digital video ad has started playing."
},
"xdm:thirdQuartiles": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, this is how we implement metrics across all the schemas in XC.

"meta:extends": [
"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "Describes the duration in which playback was paused by the user.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, this is how we implement metrics across all the schemas in XC.

"meta:extends": [
"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "The number of pause periods that occurred during playback.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, this is how we implement metrics across all the schemas in XC.

"meta:extends": [
"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "Indicates that the playhead passed the 10% marker of media based on stream length. The marker is only counted once, even if seeking backwards. If seeking forward, markers that are skipped are not counted.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, this is how we implement metrics across all the schemas in XC.

"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "Indicates that the playhead passed the 95% marker of media based on stream length. The marker is only counted once, even if seeking backwards. If seeking forward, markers that are skipped are not counted.",
"definitions": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, this is how we implement metrics across all the schemas in XC.

"meta:extends": [
"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "Marks each playback that was resumed after more than 30 minutes of buffer, pause, or stall period.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, this is how we implement metrics across all the schemas in XC.

@@ -0,0 +1,173 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lrosenthol @ogoldman @cluby-adobe @cosminci - Please re-review this specific schema as we have adopted the IPTC standard in several places and I want you opinion on the correctness and if we can use other IPTC fields in cases we have not yet. Thanks C.

Note I will look to externalize the IPTC complex objects in the \schemas\external\iptc once I figureout what legal attribution is more appropriate.

Copy link
Collaborator

@lrosenthol lrosenthol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! But still a few remaining items to resolve.

},
"xdm:conversions": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
"description": "A pre-defined action on a website triggered a conversion event to be fired"
"description": "A costumer pre-defined action(s) which triggers an event for performance evaluation."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

costumer -> customer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"media-asset-reference": {
"properties": {
"@id": {
"title": "Content ID",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this content ID and not assetID (which we already have)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is something that needs to align better. Converting to "Asset"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"type": "integer",
"description": "Length of primary media asset in seconds."
},
"xdm:showName": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is what I would think to use.

"type": "string",
"description": "Program/Series Name."
},
"xdm:assetID": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to re-open it. I am OK calling it asset, but it can't be assetID, as that is already used in the asset schema. It needs a different/unique name unless you are using it the same way - then it's OK.

"type": "string",
"description": "Program/Series Name."
},
"xdm:assetID": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One possibility is to use Iptc4xmpExt:Identifier

},
"xdm:broadcastNetwork": "nbcu",
"xdm:adLoadType": "2",
"xdm:dayPart": "DAY",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see dayPart defined anywhere in a schema...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

},
"xdm:broadcastNetwork": "nbcu",
"xdm:adLoadType": "2",
"xdm:dayPart": "DAY",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see dayPart defined anywhere in a schema...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

},
"xdm:broadcastNetwork": "nbcu",
"xdm:adLoadType": "2",
"xdm:dayPart": "DAY",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see dayPart defined anywhere in a schema...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

},
"xdm:broadcastNetwork": "nbcu",
"xdm:adLoadType": "2",
"xdm:dayPart": "DAY",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see dayPart defined anywhere in a schema...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

},
"xdm:broadcastNetwork": "nbcu",
"xdm:adLoadType": "2",
"xdm:dayPart": "DAY",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see dayPart defined anywhere in a schema...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Contributor Author

@cdegroot-adobe cdegroot-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we have resolved the outstanding questions. I will log issues for items to track which are larger then this PR. But I do not believe this PR is blocked form merging because of them.

},
"xdm:completes": {
"title": "Completes",
"$ref": "https://ns.adobe.com/xdm/data/measure",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

},
"xdm:federated": {
"title": "Federated",
"$ref": "https://ns.adobe.com/xdm/data/measure",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"description": "Indicates if an experience event was created through data federation (data sharing between customers)."
},
"xdm:clicks": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

},
"xdm:clicks": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
"description": "Click(s) actions on an advertisement."
},
"xdm:conversions": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

},
"xdm:conversions": {
"$ref": "https://ns.adobe.com/xdm/data/measure",
"description": "A pre-defined action on a website triggered a conversion event to be fired"
"description": "A costumer pre-defined action(s) which triggers an event for performance evaluation."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"meta:extends": [
"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "Describes the duration in which the playback was stalled during playback.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

"meta:extends": [
"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "The number of stall states that occurred during a playback session.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

"meta:extends": [
"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "Describes the amount of time spent by a user on a specific timed media asset.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

"meta:extends": [
"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "Describes the duration passed between video load and start.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

"https://ns.adobe.com/xdm/data/metricdefinition"
],
"description": "Describes the total amount of time spent by a user on a specific timed media asset, which includes time spent watching ads.",
"definitions": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@lrosenthol
Copy link
Collaborator

Thanks Chris - all good!
Shall I merge it @cdegroot-adobe ?

@fmeschbe fmeschbe added blocked Blocked due to another open issue v0.9.3 Scheduled for v0.9.3 and removed blocked Blocked due to another open issue labels Jul 13, 2018
… that we can have more time to review and get it right.
… future one so that we can have more time to review and get it right.
@cdegroot-adobe
Copy link
Contributor Author

@fmeschbe I have created a new PR with the 4 properties that did not stabilize adequately during the review cycle. #433

This PR #417 is ready to merge now.

@fmeschbe fmeschbe merged commit ea50992 into adobe:master Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v0.9.3 Scheduled for v0.9.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants