Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cjm 62503 move the xdm:trackingToken from option-detail.schema.json to decisionitem.schema.json #1829

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

kenadobe
Copy link
Contributor

CJM-62503.
Adding a placeholder attribute so that it can be available in AJO Code based experience editor. No data will be stored in this schema which is why I prefix it with _.
The trackingToken attribute is now moved to the decisionitem.schema.json.
Copy link
Contributor

@usankara usankara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Updated the trackingToken path to be consistent with all other attributes in this schema.
@kenadobe
Copy link
Contributor Author

I updated the trackingToken path to be consistent with all other attributes in the schema and also removed the "_" prefix from the trackingToken attribute name.

@anandphatak anandphatak self-assigned this Mar 1, 2024
@@ -104,6 +104,7 @@
"description": "Option selection type. The selection type of which the item was derived from."
},
"xdm:trackingToken": {
"meta:status": "deprecated",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenadobe , just FYI, marking a field deprecated merely means that it will not show up in the UI. But someone can still ingest data in this field.

@anandphatak anandphatak merged commit 6e763a2 into adobe:master Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants