Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip restore_cache step #4913

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

rubencarvalho
Copy link
Collaborator

@rubencarvalho rubencarvalho commented Nov 7, 2024

Description

Skipping the yarn caching in CircleCI until we stop seeing transitive dependency errors. Follow-up from #4911

Motivation and context

We still see some PRs with test-chromium failing when restoring the cache, even though we already bumped it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Copy link

github-actions bot commented Nov 7, 2024

Branch preview

Copy link

github-actions bot commented Nov 7, 2024

Tachometer results

Currently, no packages are changed by this PR...

@rubencarvalho rubencarvalho marked this pull request as ready for review November 7, 2024 13:24
@rubencarvalho rubencarvalho requested a review from a team as a code owner November 7, 2024 13:24
Copy link

github-actions bot commented Nov 7, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 1
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 251.784 kB 236.607 kB 🏆 236.835 kB
Scripts 61.735 kB 54.278 kB 🏆 54.341 kB
Stylesheet 53.94 kB 47.845 kB 🏆 48.064 kB
Document 6.19 kB 5.496 kB 5.436 kB 🏆
Font 126.898 kB 126.596 kB 🏆 126.642 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11723796027

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.189%

Totals Coverage Status
Change from base Build 11721446813: 0.0%
Covered Lines: 32313
Relevant Lines: 32735

💛 - Coveralls

Copy link
Contributor

@jnjosh jnjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume there is a subsequent PR to undo this then?

@rubencarvalho
Copy link
Collaborator Author

I assume there is a subsequent PR to undo this then?

Yes, priority now is to unblock the pipeline. Once we the corrupt cache goes away (I hope with the next batch of open PRs) we can add this back again.
This caching only saves us around 45 seconds of build time, so it is not very impactful.

@rubencarvalho rubencarvalho merged commit d82a55c into main Nov 7, 2024
45 checks passed
@rubencarvalho rubencarvalho deleted the ruben/skip-restore-cache-circleci branch November 7, 2024 16:04
nikkimk pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants