fix(icon): remove size300 suffix from chevron and checkmark icons in Spectrum 2 #4904

TarunAdobe · 2024-11-06T07:45:18Z

Description

Adds the incorrectly named chevron-down-size300 and checkmark-300 icons in Spectrum 2 to our renaming map to prevent consumer confusion. Also updates icons-demo to hide duplicate icons.

Related issue(s)

On our doc site and storybook we were seeing multiple instances of the same icon (say chevron-left) in icons-workflow package.

Motivation and context

We don't want to show the same icon twice hehe.

How has this been tested?

Go here and search for chevron icon. Notice how we don't have duplicates anymore.

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
If my change required a change to the documentation, I have updated the documentation in this pull request.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

github-actions · 2024-11-06T07:47:23Z

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

github-actions · 2024-11-06T07:49:48Z

Tachometer results

Chrome

accordion permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	678 kB	95.15ms - 96.41ms	-	faster ✔ 4% - 6% 3.83ms - 6.20ms
branch	654 kB	99.79ms - 101.79ms	slower ❌ 4% - 6% 3.83ms - 6.20ms	-

action-bar permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	740 kB	56.86ms - 58.91ms	-	unsure 🔍 -4% - +0% -2.23ms - +0.06ms
branch	715 kB	58.47ms - 59.48ms	unsure 🔍 -0% - +4% -0.06ms - +2.23ms	-

action-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	814 kB	81.80ms - 83.31ms	-	faster ✔ 1% - 5% 0.58ms - 4.19ms
branch	771 kB	83.30ms - 86.58ms	slower ❌ 1% - 5% 0.58ms - 4.19ms	-

action-group permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	836 kB	50.75ms - 52.90ms	-	faster ✔ 3% - 10% 1.29ms - 5.50ms
branch	793 kB	53.41ms - 57.03ms	slower ❌ 2% - 11% 1.29ms - 5.50ms	-

action-menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	960 kB	143.79ms - 147.01ms	-	faster ✔ 5% - 8% 7.04ms - 11.68ms
branch	916 kB	153.09ms - 156.43ms	slower ❌ 5% - 8% 7.04ms - 11.68ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	917 kB	71.52ms - 72.85ms	-	faster ✔ 6% - 9% 4.68ms - 6.66ms
branch	874 kB	77.12ms - 78.59ms	slower ❌ 6% - 9% 4.68ms - 6.66ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	916 kB	70.59ms - 71.82ms	-	faster ✔ 6% - 10% 4.85ms - 7.97ms
branch	873 kB	76.18ms - 79.05ms	slower ❌ 7% - 11% 4.85ms - 7.97ms	-

test-open-close-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1.09 MB	1875.69ms - 1878.99ms	-	unsure 🔍 -0% - +0% -4.04ms - +0.44ms
branch	1.05 MB	1877.63ms - 1880.66ms	unsure 🔍 -0% - +0% -0.44ms - +4.04ms	-

test-open-close permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1.09 MB	1882.30ms - 1885.10ms	-	unsure 🔍 +0% - +0% +0.07ms - +3.97ms
branch	1.05 MB	1880.32ms - 1883.04ms	unsure 🔍 -0% - -0% -3.97ms - -0.07ms	-

alert-banner permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	689 kB	14.23ms - 14.51ms	-	faster ✔ 2% - 5% 0.23ms - 0.74ms
branch	664 kB	14.64ms - 15.07ms	slower ❌ 2% - 5% 0.23ms - 0.74ms	-

alert-dialog permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	739 kB	110.74ms - 112.77ms	-	faster ✔ 1% - 3% 1.03ms - 3.37ms
branch	696 kB	113.38ms - 114.54ms	slower ❌ 1% - 3% 1.03ms - 3.37ms	-

breadcrumbs permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	979 kB	535.17ms - 541.13ms	-	unsure 🔍 -1% - +0% -7.47ms - +1.20ms
branch	935 kB	538.14ms - 544.43ms	unsure 🔍 -0% - +1% -1.20ms - +7.47ms	-

button-group permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	731 kB	46.20ms - 47.14ms	-	faster ✔ 2% - 5% 1.09ms - 2.46ms
branch	688 kB	47.95ms - 48.95ms	slower ❌ 2% - 5% 1.09ms - 2.46ms	-

button permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	739 kB	53.96ms - 58.29ms	-	unsure 🔍 -7% - +2% -4.21ms - +1.18ms
branch	696 kB	56.03ms - 59.25ms	unsure 🔍 -2% - +8% -1.18ms - +4.21ms	-

card permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1.06 MB	33.99ms - 34.60ms	-	faster ✔ 14% - 16% 5.70ms - 6.55ms
branch	757 kB	40.13ms - 40.71ms	slower ❌ 17% - 19% 5.70ms - 6.55ms	-

checkbox permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	680 kB	46.97ms - 47.74ms	-	faster ✔ 0% - 2% 0.03ms - 1.05ms
branch	656 kB	47.56ms - 48.24ms	slower ❌ 0% - 2% 0.03ms - 1.05ms	-

coachmark permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	910 kB	95.43ms - 97.51ms	-	faster ✔ 3% - 6% 2.47ms - 6.16ms
branch	864 kB	99.26ms - 102.31ms	slower ❌ 3% - 6% 2.47ms - 6.16ms	-

color-field permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	748 kB	46.48ms - 48.02ms	-	faster ✔ 2% - 9% 0.68ms - 4.36ms
branch	724 kB	48.10ms - 51.44ms	slower ❌ 1% - 9% 0.68ms - 4.36ms	-

combobox permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1 MB	42.72ms - 43.25ms	-	faster ✔ 2% - 4% 0.66ms - 1.58ms
branch	957 kB	43.73ms - 44.48ms	slower ❌ 2% - 4% 0.66ms - 1.58ms	-

light-dom-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1 MB	407.79ms - 412.35ms	-	faster ✔ 1% - 3% 5.93ms - 13.65ms
branch	957 kB	416.74ms - 422.98ms	slower ❌ 1% - 3% 5.93ms - 13.65ms	-

contextual-help permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	944 kB	55.92ms - 57.59ms	-	faster ✔ 2% - 6% 1.23ms - 3.37ms
branch	898 kB	58.39ms - 59.73ms	slower ❌ 2% - 6% 1.23ms - 3.37ms	-

dialog permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	803 kB	81.33ms - 83.71ms	-	unsure 🔍 -2% - +1% -1.51ms - +0.97ms
branch	759 kB	82.42ms - 83.16ms	unsure 🔍 -1% - +2% -0.97ms - +1.51ms	-

field-group permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	686 kB	46.76ms - 47.75ms	-	faster ✔ 2% - 6% 1.18ms - 3.12ms
branch	662 kB	48.57ms - 50.23ms	slower ❌ 2% - 7% 1.18ms - 3.12ms	-

field-label permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	651 kB	22.64ms - 23.04ms	-	faster ✔ 1% - 3% 0.22ms - 0.77ms
branch	627 kB	23.15ms - 23.51ms	slower ❌ 1% - 3% 0.22ms - 0.77ms	-

help-text permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	646 kB	12.25ms - 13.10ms	-	unsure 🔍 -5% - +2% -0.71ms - +0.32ms
branch	622 kB	12.58ms - 13.15ms	unsure 🔍 -3% - +6% -0.32ms - +0.71ms	-

icon permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	652 kB	15.28ms - 16.27ms	-	unsure 🔍 -4% - +4% -0.70ms - +0.63ms
branch	627 kB	15.37ms - 16.26ms	unsure 🔍 -4% - +4% -0.63ms - +0.70ms	-

icons permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	628 kB	31.48ms - 31.83ms	-	faster ✔ 1% - 2% 0.30ms - 0.80ms
branch	605 kB	32.03ms - 32.38ms	slower ❌ 1% - 3% 0.30ms - 0.80ms	-

infield-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	661 kB	16.80ms - 19.18ms	-	faster ✔ 0% - 13% 0.01ms - 2.59ms
branch	636 kB	18.79ms - 19.79ms	unsure 🔍 -0% - +15% +0.01ms - +2.59ms	-

menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	741 kB	219.86ms - 230.49ms	-	unsure 🔍 -5% - +1% -10.55ms - +2.01ms
branch	716 kB	226.09ms - 232.80ms	unsure 🔍 -1% - +5% -2.01ms - +10.55ms	-

meter permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	668 kB	49.63ms - 50.28ms	-	faster ✔ 5% - 7% 2.46ms - 3.57ms
branch	643 kB	52.51ms - 53.42ms	slower ❌ 5% - 7% 2.46ms - 3.57ms	-

number-field permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	795 kB	75.92ms - 77.15ms	-	faster ✔ 8% - 11% 6.85ms - 9.11ms
branch	770 kB	83.57ms - 85.47ms	slower ❌ 9% - 12% 6.85ms - 9.11ms	-

overlay permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	983 kB	438.62ms - 448.85ms	-	unsure 🔍 -2% - +1% -7.60ms - +3.70ms
branch	939 kB	443.29ms - 448.09ms	unsure 🔍 -1% - +2% -3.70ms - +7.60ms	-

directive-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1.06 MB	26.13ms - 26.69ms	-	faster ✔ 6% - 10% 1.69ms - 2.79ms
branch	1.02 MB	28.17ms - 29.13ms	slower ❌ 6% - 11% 1.69ms - 2.79ms	-

element-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1.05 MB	359.54ms - 369.02ms	-	faster ✔ 1% - 4% 3.21ms - 13.48ms
branch	1.01 MB	370.65ms - 374.60ms	slower ❌ 1% - 4% 3.21ms - 13.48ms	-

lazy-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	851 kB	44.66ms - 45.56ms	-	faster ✔ 7% - 10% 3.49ms - 5.02ms
branch	805 kB	48.75ms - 49.99ms	slower ❌ 8% - 11% 3.49ms - 5.02ms	-

picker-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	674 kB	30.34ms - 32.18ms	-	unsure 🔍 -10% - +0% -3.17ms - +0.14ms
branch	650 kB	31.40ms - 34.15ms	unsure 🔍 -1% - +10% -0.14ms - +3.17ms	-

picker permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	817 kB	512.09ms - 520.28ms	-	faster ✔ 2% - 4% 10.35ms - 23.70ms
branch	774 kB	527.94ms - 538.48ms	slower ❌ 2% - 5% 10.35ms - 23.70ms	-

popover permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	817 kB	108.11ms - 108.92ms	-	faster ✔ 1% - 3% 1.44ms - 2.82ms
branch	774 kB	110.08ms - 111.21ms	slower ❌ 1% - 3% 1.44ms - 2.82ms	-

progress-bar permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	666 kB	30.90ms - 31.51ms	-	faster ✔ 1% - 4% 0.31ms - 1.17ms
branch	642 kB	31.64ms - 32.25ms	slower ❌ 1% - 4% 0.31ms - 1.17ms	-

radio permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	663 kB	38.74ms - 39.49ms	-	faster ✔ 3% - 5% 1.05ms - 2.16ms
branch	639 kB	40.31ms - 41.13ms	slower ❌ 3% - 6% 1.05ms - 2.16ms	-

search permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	738 kB	44.40ms - 45.85ms	-	faster ✔ 1% - 5% 0.64ms - 2.32ms
branch	713 kB	46.18ms - 47.03ms	slower ❌ 1% - 5% 0.64ms - 2.32ms	-

slider permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	742 kB	79.16ms - 81.80ms	-	faster ✔ 2% - 6% 1.94ms - 4.88ms
branch	717 kB	83.24ms - 84.55ms	slower ❌ 2% - 6% 1.94ms - 4.88ms	-

swatch permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	669 kB	15.66ms - 15.97ms	-	faster ✔ 6% - 8% 0.99ms - 1.42ms
branch	645 kB	16.87ms - 17.18ms	slower ❌ 6% - 9% 0.99ms - 1.42ms	-

switch permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	657 kB	16.77ms - 17.79ms	-	faster ✔ 3% - 12% 0.52ms - 2.32ms
branch	633 kB	17.97ms - 19.44ms	slower ❌ 3% - 14% 0.52ms - 2.32ms	-

table permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	802 kB	128.96ms - 134.08ms	-	faster ✔ 0% - 4% 0.36ms - 6.07ms
branch	753 kB	133.48ms - 135.98ms	slower ❌ 0% - 5% 0.36ms - 6.07ms	-

tabs permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	683 kB	117.90ms - 121.48ms	-	unsure 🔍 -3% - +1% -3.28ms - +0.66ms
branch	658 kB	120.18ms - 121.81ms	unsure 🔍 -1% - +3% -0.66ms - +3.28ms	-

tags permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	712 kB	15.02ms - 15.25ms	-	unsure 🔍 -0% - +2% -0.05ms - +0.27ms
branch	688 kB	14.91ms - 15.14ms	unsure 🔍 -2% - +0% -0.27ms - +0.05ms	-

textfield permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	693 kB	26.47ms - 26.92ms	-	faster ✔ 9% - 11% 2.53ms - 3.40ms
branch	669 kB	29.28ms - 30.03ms	slower ❌ 9% - 13% 2.53ms - 3.40ms	-

toast permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	696 kB	32.26ms - 33.43ms	-	faster ✔ 3% - 9% 0.86ms - 3.23ms
branch	672 kB	33.86ms - 35.92ms	slower ❌ 3% - 10% 0.86ms - 3.23ms	-

tooltip permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	874 kB	36.17ms - 36.84ms	-	faster ✔ 3% - 6% 1.31ms - 2.27ms
branch	830 kB	37.95ms - 38.63ms	slower ❌ 4% - 6% 1.31ms - 2.27ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	831 kB	25.88ms - 26.42ms	-	faster ✔ 7% - 10% 2.03ms - 2.91ms
branch	788 kB	28.27ms - 28.97ms	slower ❌ 8% - 11% 2.03ms - 2.91ms	-

test-element permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	957 kB	55.54ms - 56.70ms	-	faster ✔ 4% - 6% 2.23ms - 3.81ms
branch	910 kB	58.61ms - 59.68ms	slower ❌ 4% - 7% 2.23ms - 3.81ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	932 kB	44.78ms - 45.71ms	-	faster ✔ 6% - 9% 3.15ms - 4.60ms
branch	886 kB	48.56ms - 49.68ms	slower ❌ 7% - 10% 3.15ms - 4.60ms	-

top-nav permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	689 kB	41.94ms - 44.06ms	-	faster ✔ 0% - 9% 0.02ms - 3.92ms
branch	664 kB	43.33ms - 46.61ms	unsure 🔍 -0% - +9% +0.02ms - +3.92ms	-

truncated permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	788 kB	64.05ms - 67.76ms	-	unsure 🔍 -8% - -0% -5.91ms - +0.07ms
branch	761 kB	66.48ms - 71.18ms	unsure 🔍 -0% - +9% -0.07ms - +5.91ms	-

Firefox

accordion permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	678 kB	191.24ms - 199.20ms	-	faster ✔ 2% - 7% 3.85ms - 13.87ms
branch	654 kB	201.04ms - 207.12ms	slower ❌ 2% - 7% 3.85ms - 13.87ms	-

action-bar permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	740 kB	120.62ms - 128.22ms	-	unsure 🔍 -8% - +1% -10.20ms - +0.80ms
branch	715 kB	125.14ms - 133.10ms	unsure 🔍 -1% - +8% -0.80ms - +10.20ms	-

action-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	814 kB	168.85ms - 180.31ms	-	unsure 🔍 -6% - +3% -10.25ms - +4.57ms
branch	771 kB	172.71ms - 182.13ms	unsure 🔍 -3% - +6% -4.57ms - +10.25ms	-

action-group permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	836 kB	116.61ms - 125.11ms	-	faster ✔ 1% - 10% 0.99ms - 12.73ms
branch	793 kB	123.66ms - 131.78ms	slower ❌ 1% - 11% 0.99ms - 12.73ms	-

action-menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	960 kB	289.29ms - 292.15ms	-	faster ✔ 12% - 14% 41.40ms - 46.44ms
branch	916 kB	332.56ms - 336.72ms	slower ❌ 14% - 16% 41.40ms - 46.44ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	917 kB	156.56ms - 160.24ms	-	slower ❌ 8% - 11% 11.85ms - 16.19ms
branch	874 kB	143.23ms - 145.53ms	faster ✔ 8% - 10% 11.85ms - 16.19ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	916 kB	135.51ms - 138.93ms	-	faster ✔ 2% - 6% 3.03ms - 8.29ms
branch	873 kB	140.89ms - 144.87ms	slower ❌ 2% - 6% 3.03ms - 8.29ms	-

test-open-close-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1.09 MB	1888.28ms - 1903.28ms	-	unsure 🔍 -1% - +0% -12.72ms - +3.60ms
branch	1.05 MB	1897.11ms - 1903.57ms	unsure 🔍 -0% - +1% -3.60ms - +12.72ms	-

test-open-close permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1.09 MB	1898.69ms - 1902.55ms	-	unsure 🔍 -0% - +0% -3.64ms - +1.80ms
branch	1.05 MB	1899.62ms - 1903.46ms	unsure 🔍 -0% - +0% -1.80ms - +3.64ms	-

alert-banner permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	689 kB	30.70ms - 34.02ms	-	unsure 🔍 -8% - +6% -2.48ms - +2.12ms
branch	664 kB	30.95ms - 34.13ms	unsure 🔍 -7% - +8% -2.12ms - +2.48ms	-

alert-dialog permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	739 kB	206.62ms - 213.94ms	-	unsure 🔍 -3% - +3% -6.86ms - +6.82ms
branch	696 kB	204.52ms - 216.08ms	unsure 🔍 -3% - +3% -6.82ms - +6.86ms	-

breadcrumbs permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	979 kB	844.80ms - 875.56ms	-	unsure 🔍 -2% - +2% -18.16ms - +13.80ms
branch	935 kB	858.01ms - 866.71ms	unsure 🔍 -2% - +2% -13.80ms - +18.16ms	-

button-group permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	731 kB	109.92ms - 117.92ms	-	unsure 🔍 -9% - +0% -11.19ms - +0.47ms
branch	688 kB	115.03ms - 123.53ms	unsure 🔍 -1% - +10% -0.47ms - +11.19ms	-

button permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	739 kB	128.09ms - 135.27ms	-	unsure 🔍 -4% - +3% -5.77ms - +4.61ms
branch	696 kB	128.51ms - 136.01ms	unsure 🔍 -4% - +4% -4.61ms - +5.77ms	-

card permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1.06 MB	69.74ms - 75.70ms	-	faster ✔ 7% - 15% 6.06ms - 12.82ms
branch	757 kB	80.57ms - 83.75ms	slower ❌ 8% - 18% 6.06ms - 12.82ms	-

checkbox permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	680 kB	107.76ms - 116.48ms	-	unsure 🔍 -6% - +5% -6.52ms - +5.28ms
branch	656 kB	108.78ms - 116.70ms	unsure 🔍 -5% - +6% -5.28ms - +6.52ms	-

coachmark permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	910 kB	189.90ms - 192.54ms	-	faster ✔ 4% - 6% 7.09ms - 11.11ms
branch	864 kB	198.81ms - 201.83ms	slower ❌ 4% - 6% 7.09ms - 11.11ms	-

color-field permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	756 kB	85.75ms - 91.53ms	-	unsure 🔍 -4% - +3% -3.38ms - +3.06ms
branch	732 kB	87.39ms - 90.21ms	unsure 🔍 -3% - +4% -3.06ms - +3.38ms	-

combobox permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1 MB	70.67ms - 74.69ms	-	unsure 🔍 -4% - +2% -3.00ms - +1.72ms
branch	957 kB	72.08ms - 74.56ms	unsure 🔍 -2% - +4% -1.72ms - +3.00ms	-

light-dom-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1 MB	751.62ms - 769.74ms	-	slower ❌ 5% - 8% 34.96ms - 58.00ms
branch	957 kB	707.09ms - 721.31ms	faster ✔ 5% - 8% 34.96ms - 58.00ms	-

contextual-help permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	944 kB	114.14ms - 120.46ms	-	faster ✔ 0% - 8% 0.19ms - 9.33ms
branch	898 kB	118.76ms - 125.36ms	slower ❌ 0% - 8% 0.19ms - 9.33ms	-

dialog permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	803 kB	127.27ms - 133.21ms	-	unsure 🔍 -8% - +0% -10.37ms - +0.25ms
branch	759 kB	130.90ms - 139.70ms	unsure 🔍 -0% - +8% -0.25ms - +10.37ms	-

field-group permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	686 kB	102.37ms - 113.99ms	-	unsure 🔍 -10% - +4% -10.93ms - +4.65ms
branch	662 kB	106.13ms - 116.51ms	unsure 🔍 -4% - +10% -4.65ms - +10.93ms	-

field-label permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	651 kB	54.63ms - 61.49ms	-	unsure 🔍 -11% - +3% -6.95ms - +1.63ms
branch	627 kB	58.15ms - 63.29ms	unsure 🔍 -3% - +12% -1.63ms - +6.95ms	-

help-text permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	646 kB	26.54ms - 28.70ms	-	unsure 🔍 -8% - +2% -2.43ms - +0.67ms
branch	622 kB	27.39ms - 29.61ms	unsure 🔍 -3% - +9% -0.67ms - +2.43ms	-

icon permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	652 kB	38.27ms - 42.57ms	-	unsure 🔍 -6% - +9% -2.23ms - +3.67ms
branch	627 kB	37.67ms - 41.73ms	unsure 🔍 -9% - +5% -3.67ms - +2.23ms	-

icons permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	628 kB	55.37ms - 58.47ms	-	unsure 🔍 -4% - +3% -2.29ms - +1.65ms
branch	605 kB	56.03ms - 58.45ms	unsure 🔍 -3% - +4% -1.65ms - +2.29ms	-

infield-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	661 kB	41.36ms - 44.64ms	-	faster ✔ 3% - 14% 1.20ms - 6.64ms
branch	636 kB	44.75ms - 49.09ms	slower ❌ 3% - 16% 1.20ms - 6.64ms	-

menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	741 kB	404.85ms - 418.55ms	-	unsure 🔍 -4% - +1% -19.02ms - +2.54ms
branch	716 kB	411.62ms - 428.26ms	unsure 🔍 -1% - +5% -2.54ms - +19.02ms	-

meter permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	668 kB	87.91ms - 93.73ms	-	unsure 🔍 -6% - +3% -5.12ms - +2.80ms
branch	643 kB	89.30ms - 94.66ms	unsure 🔍 -3% - +6% -2.80ms - +5.12ms	-

number-field permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	795 kB	157.58ms - 166.70ms	-	faster ✔ 5% - 11% 8.05ms - 20.11ms
branch	770 kB	172.27ms - 180.17ms	slower ❌ 5% - 13% 8.05ms - 20.11ms	-

overlay permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1.06 MB	667.10ms - 692.14ms	-	slower ❌ 6% - 10% 36.27ms - 61.61ms
branch	1.01 MB	628.68ms - 632.68ms	faster ✔ 5% - 9% 36.27ms - 61.61ms	-

directive-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1.06 MB	52.47ms - 53.37ms	-	faster ✔ 3% - 6% 1.63ms - 3.09ms
branch	1.02 MB	54.71ms - 55.85ms	slower ❌ 3% - 6% 1.63ms - 3.09ms	-

element-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	1.05 MB	682.56ms - 689.80ms	-	slower ❌ 6% - 8% 40.35ms - 49.97ms
branch	1.01 MB	637.85ms - 644.19ms	faster ✔ 6% - 7% 40.35ms - 49.97ms	-

lazy-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	851 kB	96.51ms - 105.21ms	-	unsure 🔍 -5% - +5% -4.79ms - +4.55ms
branch	805 kB	99.28ms - 102.68ms	unsure 🔍 -5% - +5% -4.55ms - +4.79ms	-

picker-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	674 kB	64.32ms - 68.92ms	-	unsure 🔍 -8% - +1% -5.89ms - +1.05ms
branch	650 kB	66.44ms - 71.64ms	unsure 🔍 -2% - +9% -1.05ms - +5.89ms	-

picker permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	817 kB	997.33ms - 1006.27ms	-	faster ✔ 4% - 7% 46.13ms - 78.83ms
branch	774 kB	1048.55ms - 1080.01ms	slower ❌ 5% - 8% 46.13ms - 78.83ms	-

popover permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	817 kB	150.21ms - 160.23ms	-	unsure 🔍 -7% - +1% -11.62ms - +1.58ms
branch	774 kB	155.94ms - 164.54ms	unsure 🔍 -1% - +8% -1.58ms - +11.62ms	-

progress-bar permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	666 kB	61.60ms - 64.64ms	-	unsure 🔍 -7% - +0% -4.84ms - +0.32ms
branch	642 kB	63.30ms - 67.46ms	unsure 🔍 -1% - +8% -0.32ms - +4.84ms	-

radio permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	663 kB	77.40ms - 83.48ms	-	unsure 🔍 -6% - +3% -4.86ms - +2.86ms
branch	639 kB	79.06ms - 83.82ms	unsure 🔍 -4% - +6% -2.86ms - +4.86ms	-

search permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	738 kB	87.72ms - 92.72ms	-	faster ✔ 3% - 10% 2.32ms - 10.00ms
branch	713 kB	93.47ms - 99.29ms	slower ❌ 2% - 11% 2.32ms - 10.00ms	-

slider permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	742 kB	160.52ms - 170.20ms	-	unsure 🔍 -5% - +2% -9.20ms - +2.72ms
branch	717 kB	165.12ms - 172.08ms	unsure 🔍 -2% - +6% -2.72ms - +9.20ms	-

swatch permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	669 kB	39.12ms - 43.20ms	-	unsure 🔍 -6% - +7% -2.36ms - +2.84ms
branch	645 kB	39.30ms - 42.54ms	unsure 🔍 -7% - +6% -2.84ms - +2.36ms	-

switch permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	657 kB	40.03ms - 43.13ms	-	faster ✔ 1% - 12% 0.30ms - 5.34ms
branch	633 kB	42.41ms - 46.39ms	slower ❌ 1% - 13% 0.30ms - 5.34ms	-

table permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	802 kB	285.77ms - 297.83ms	-	unsure 🔍 -4% - +1% -11.66ms - +3.62ms
branch	753 kB	291.12ms - 300.52ms	unsure 🔍 -1% - +4% -3.62ms - +11.66ms	-

tabs permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	683 kB	202.98ms - 211.94ms	-	unsure 🔍 -6% - +0% -13.68ms - +0.84ms
branch	658 kB	208.17ms - 219.59ms	unsure 🔍 -0% - +7% -0.84ms - +13.68ms	-

tags permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	712 kB	34.31ms - 38.45ms	-	unsure 🔍 -4% - +12% -1.28ms - +4.04ms
branch	688 kB	33.33ms - 36.67ms	unsure 🔍 -11% - +3% -4.04ms - +1.28ms	-

textfield permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	693 kB	50.39ms - 53.49ms	-	faster ✔ 4% - 13% 2.10ms - 7.58ms
branch	669 kB	54.53ms - 59.03ms	slower ❌ 4% - 15% 2.10ms - 7.58ms	-

toast permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	696 kB	72.50ms - 78.82ms	-	unsure 🔍 -8% - +2% -6.51ms - +1.63ms
branch	672 kB	75.54ms - 80.66ms	unsure 🔍 -2% - +9% -1.63ms - +6.51ms	-

tooltip permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	956 kB	85.82ms - 92.46ms	-	slower ❌ 12% - 22% 9.19ms - 16.85ms
branch	910 kB	74.20ms - 78.04ms	faster ✔ 11% - 18% 9.19ms - 16.85ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	831 kB	50.39ms - 52.93ms	-	faster ✔ 1% - 7% 0.58ms - 3.58ms
branch	788 kB	52.93ms - 54.55ms	slower ❌ 1% - 7% 0.58ms - 3.58ms	-

test-element permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	957 kB	148.53ms - 152.83ms	-	slower ❌ 12% - 18% 16.56ms - 22.76ms
branch	910 kB	128.79ms - 133.25ms	faster ✔ 11% - 15% 16.56ms - 22.76ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	932 kB	88.16ms - 91.12ms	-	faster ✔ 22% - 29% 24.58ms - 36.58ms
branch	886 kB	114.40ms - 126.04ms	slower ❌ 27% - 41% 24.58ms - 36.58ms	-

top-nav permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	689 kB	94.78ms - 103.14ms	-	unsure 🔍 -10% - +0% -10.87ms - +0.39ms
branch	664 kB	100.43ms - 107.97ms	unsure 🔍 -1% - +11% -0.39ms - +10.87ms	-

truncated permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	788 kB	110.06ms - 119.06ms	-	unsure 🔍 -9% - +1% -10.33ms - +1.37ms
branch	761 kB	115.30ms - 122.78ms	unsure 🔍 -1% - +9% -1.37ms - +10.33ms	-

github-actions · 2024-11-06T07:51:51Z

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.99	0.99	0.99
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category	Latest	Main	Branch
Total	252.146 kB	236.484 kB 🏆	236.612 kB
Scripts	62.107 kB	54.109 kB	54.068 kB 🏆
Stylesheet	53.848 kB	47.979 kB	47.895 kB 🏆
Document	6.188 kB	5.434 kB 🏆	5.456 kB
Font	127.033 kB	126.613 kB 🏆	126.72 kB

Request Count

Category	Latest	Main	Branch
Total	52	52	52
Scripts	41	41	41
Stylesheet	5	5	5
Document	1	1	1
Font	2	2	2

coveralls · 2024-11-06T07:52:03Z

Pull Request Test Coverage Report for Build 11737697193

Details

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.01%) to 98.194%

Files with Coverage Reduction	New Missed Lines	%
tools/theme/src/Theme.ts	2	98.13%

Totals
Change from base Build 11737131007:	0.01%
Covered Lines:	32314
Relevant Lines:	32732

💛 - Coveralls

packages/iconset/stories/icons-demo.ts

packages/icons-workflow/bin/build.js

…Spectrum 2 (#4904)

chore: updates icons-demo to not show duplicate icons

eff6691

TarunAdobe requested a review from a team as a code owner November 6, 2024 07:45

TarunAdobe and others added 2 commits November 6, 2024 16:09

chore: updated golden image hash

4ac3113

chore: serve JSON files as js

d0435d1

TarunAdobe self-assigned this Nov 6, 2024

rubencarvalho reviewed Nov 6, 2024

View reviewed changes

packages/iconset/stories/icons-demo.ts Outdated Show resolved Hide resolved

rubencarvalho reviewed Nov 6, 2024

View reviewed changes

packages/iconset/stories/icons-demo.ts Outdated Show resolved Hide resolved

TarunAdobe changed the title ~~chore: updates icons-demo to not show duplicate icons~~ chore: update icons-demo package to not show duplicate icons Nov 7, 2024

TarunAdobe force-pushed the ttomar/duplicate-icons branch from 3540a8f to eb40136 Compare November 7, 2024 09:08

TarunAdobe requested a review from rubencarvalho November 7, 2024 09:09

TarunAdobe force-pushed the ttomar/duplicate-icons branch from eb40136 to 16758bb Compare November 7, 2024 09:55

chore: abstract icon filtering function

ce82eab

TarunAdobe force-pushed the ttomar/duplicate-icons branch from 16758bb to ce82eab Compare November 7, 2024 11:22

TarunAdobe and others added 4 commits November 7, 2024 17:23

fix: update chevrondown and checkmark icon names

2908092

Merge branch 'main' into ttomar/duplicate-icons

ddc0382

chore: update golden image hash

225e9b5

Merge branch 'main' into ttomar/duplicate-icons

4060dba

rubencarvalho reviewed Nov 7, 2024

View reviewed changes

packages/icons-workflow/bin/build.js Outdated Show resolved Hide resolved

chore: improve code structure

f626909

rubencarvalho reviewed Nov 7, 2024

View reviewed changes

packages/icons-workflow/bin/build.js Outdated Show resolved Hide resolved

rubencarvalho reviewed Nov 7, 2024

View reviewed changes

packages/icons-workflow/bin/build.js Outdated Show resolved Hide resolved

rubencarvalho changed the title ~~chore: update icons-demo package to not show duplicate icons~~ fix(icon): remove size300 suffix from chevron and checkmark icons in Spectrum 2 Nov 7, 2024

chore: update golden image hash

5099a83

TarunAdobe force-pushed the ttomar/duplicate-icons branch from 4e91d1d to 5099a83 Compare November 8, 2024 06:49

TarunAdobe added 2 commits November 8, 2024 12:20

chore: merge main

007d8fc

chore: update golden image hash

ffc4b11

TarunAdobe requested a review from rubencarvalho November 8, 2024 07:49

rubencarvalho reviewed Nov 8, 2024

View reviewed changes

packages/icons-workflow/bin/build.js Show resolved Hide resolved

rubencarvalho approved these changes Nov 8, 2024

View reviewed changes

rubencarvalho merged commit a22f42b into main Nov 8, 2024
45 checks passed

rubencarvalho deleted the ttomar/duplicate-icons branch November 8, 2024 09:47

nikkimk pushed a commit that referenced this pull request Nov 19, 2024

fix(icon): remove size300 suffix from chevron and checkmark icons in …

852f069

…Spectrum 2 (#4904)

fix(icon): remove size300 suffix from chevron and checkmark icons in Spectrum 2 #4904

fix(icon): remove size300 suffix from chevron and checkmark icons in Spectrum 2 #4904

Conversation

TarunAdobe commented Nov 6, 2024 • edited by rubencarvalho Loading

Description

Related issue(s)

Motivation and context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Checklist

Best practices

github-actions bot commented Nov 6, 2024 • edited Loading

Branch preview

github-actions bot commented Nov 6, 2024 • edited Loading

Tachometer results

accordion permalink

basic-test

action-bar permalink

basic-test

action-button permalink

basic-test

action-group permalink

basic-test

action-menu permalink

test-basic

test-directive permalink

test-lazy permalink

test-open-close-directive permalink

test-open-close permalink

alert-banner permalink

basic-test

alert-dialog permalink

basic-test

breadcrumbs permalink

basic-test

button-group permalink

basic-test

button permalink

test-basic

card permalink

test-basic

checkbox permalink

test-basic

coachmark permalink

basic-test

color-field permalink

basic-test

combobox permalink

basic-test

light-dom-test permalink

contextual-help permalink

basic-test

dialog permalink

basic-test

field-group permalink

basic-test

field-label permalink

basic-test

help-text permalink

basic-test

icon permalink

test-basic

icons permalink

test-basic

infield-button permalink

basic-test

menu permalink

test-basic

meter permalink

basic-test

number-field permalink

basic-test

overlay permalink

basic-test

directive-test permalink

element-test permalink

lazy-test permalink

picker-button permalink

basic-test

TarunAdobe commented Nov 6, 2024 •

edited by rubencarvalho

Loading

github-actions bot commented Nov 6, 2024 •

edited

Loading

github-actions bot commented Nov 6, 2024 •

edited

Loading