chore: refactor sp-theme #4743
Merged
chore: refactor sp-theme #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10902516554Details
💛 - Coveralls |
rubencarvalho
force-pushed
the
ruben/chore-theme-refactor
branch
from
8b4b023 to
7c0fd57
Compare
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeaction-bar permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
breadcrumbs permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
contextual-help permalinkbasic-test
menu permalinktest-basic
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker permalinkbasic-test
popover permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
truncated permalinkbasic-test
Firefoxaction-bar permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
breadcrumbs permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
contextual-help permalinkbasic-test
menu permalinktest-basic
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker permalinkbasic-test
popover permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
truncated permalinkbasic-test
|
rubencarvalho
force-pushed
the
ruben/chore-theme-refactor
branch
from
828abce to
b68d601
Compare
jnjosh
reviewed
Sep 12, 2024
tools/theme/src/Theme.ts
Outdated
| 'https://opensource.adobe.com/spectrum-web-components/tools/themes/#deprecation', | ||
| { level: 'deprecation' } | ||
| ); | ||
| if (value === 'spectrum-two') { |
There was a problem hiding this comment.
This reads weird to me in that if you are on spectrum-two you'd get two warnings, one saying deprecated and one saying beta? I guess that's only if they use the theme property though. Anyway, Beta seems like a long term possibility so I wonder if it makes sense to just create a warnBetaSystem which would make the call site clearer too.
There was a problem hiding this comment.
It does look to me like this would get called even if they used system instead of theme though, so probably worth breaking it a part? Or something?
There was a problem hiding this comment.
Oops, you are right. After moving this debugging code around it ended up becoming messy. I have now cleaned it up, so it now only warns once about the deprecated use of theme.
Following your suggestion, I also created a dedicated beta warning (for S2) that we can remove if we want. Do we want to remove this beta warning? cc: @Rajdeepc
There was a problem hiding this comment.
Yes it make sense to remove the beta warning for now! We will add this step by step once we start rolling things for S2. Thanks for doing this! Appreciate it
Rajdeepc
requested changes
Sep 13, 2024
tools/theme/src/Theme.ts
Outdated
| { level: 'deprecation' } | ||
| ); | ||
| if (value === 'spectrum-two') { | ||
| window.__swc.warn( |
There was a problem hiding this comment.
Do we need this warning now?
There was a problem hiding this comment.
I am not sure, maybe we remove on 1.0.0?
There was a problem hiding this comment.
Yes let's remove on 1.0.0? Maybe add this to the TODO list.
rubencarvalho
force-pushed
the
ruben/chore-theme-refactor
branch
from
ce72753 to
b68d601
Compare
Rajdeepc
previously approved these changes
Sep 16, 2024
rubencarvalho
dismissed stale reviews from Rajdeepc and TarunAdobe
via
4721f5c
11 tasks
Rajdeepc
approved these changes
Sep 17, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed unnecessary polyfills and refactored the
sp-themecode.Related issue(s)
Motivation and context
Our
sp-themeneeds some love, we will probably build upon it to enable more complex functionality in our system (e.g., using context). So this is just a first step on cleaning it up a bit.How has this been tested?
Existing tests, as this is purely a refactor.
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.