feat(number-field): add missing --mod-* tokens
#4565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rocss
changed the title
--mod-* tokens
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromenumber-field permalinkbasic-test
slider permalinktest-basic
Firefoxnumber-field permalinkbasic-test
slider permalinktest-basic
|
Rajdeepc
added a commit
that referenced
this pull request
Jun 18, 2024
* chore: release new versions #publish * chore(overlay): overlay-trigger adds receives focus attribute (#4558) * chore(overlay): overlay-trigger adds receives focus attribute * chore(overlay): added storybook * chore(overlay): updated golden image cache --------- Co-authored-by: Rajdeep Chandra <rajdeepchandra@rajdeeps-mbp-2.macromedia.com> Co-authored-by: Rajdeep Chandra <rajdeepchandra@Rajdeeps-MacBook-Pro-2.local> * feat: add missing --mod-* tokens for number-field (#4565) Co-authored-by: rmanole <rmanole@adobe.com> --------- Co-authored-by: Rajdeep Chandra <rajdeepchandra@Rajdeeps-MacBook-Pro-2.local> Co-authored-by: Rajdeep Chandra <rajrock38@gmail.com> Co-authored-by: Rajdeep Chandra <rajdeepchandra@rajdeeps-mbp-2.macromedia.com> Co-authored-by: rmanole <rmanole@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two more
--mod-*tokens as per #4527--mod-textfield-border-widthand
--mod-textfield-border-color.I did not add a mod token for
--spectrum-textfield-corner-radiusbecause the focus outline would look weird if you modify this CSS property.Related issue(s)
sp-number-fieldcannot be styled using--mod-*variables #4527Motivation and context
Consumers are able to override border's width and color when
hide-stepperis true.How has this been tested?
--mod-textfield-border-widthand--mod-textfield-border-coloron thesp-number-fieldcomponentScreenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.