deprecation: color lightest and darkest #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajdeepc
changed the title
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeaction-bar permalinkbasic-test
action-menu permalinktest-basic
banner permalinktest-basic
card permalinktest-basic
coachmark permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
menu permalinktest-basic
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker permalinkbasic-test
popover permalinktest-basic
quick-actions permalinkbasic-test
slider permalinktest-basic
split-button permalinkbasic-test
tooltip permalinktest-basic
test-directive permalink
Firefoxaction-bar permalinkbasic-test
action-menu permalinktest-basic
banner permalinktest-basic
card permalinktest-basic
coachmark permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
menu permalinktest-basic
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker permalinkbasic-test
popover permalinktest-basic
quick-actions permalinkbasic-test
slider permalinktest-basic
split-button permalinkbasic-test
tooltip permalinktest-basic
test-directive permalink
|
Westbrook
reviewed
Mar 14, 2024
| <sp-icon-alert class="spectrum-InLineAlert-icon" dir="ltr" aria-hidden="true"></sp-icon-alert> | ||
| </div> | ||
| <div class="spectrum-InLineAlert-content"> | ||
| This component has been deprecated.<br></br> | ||
| {% if isComponent %} | ||
| This component will be deprecated. |
There was a problem hiding this comment.
Should this be package vs component?
There was a problem hiding this comment.
So you want to bifurcate as a package and a tool?
There was a problem hiding this comment.
Tricky intersection of naming. Here, by "package", I mean @spectrum-web-components/... as found on NPM. So any directory that gets published would satisfy this meaning.
Maybe the more flexible approach would be to leverage the deprecationNotice only, and require that we make we include text of this shape there rather than centralizing it here?
There was a problem hiding this comment.
Yes we can make something like @spectrum-web-components/packages/banner will be deprecated instead of This component will be deprecated maybe something like this?
added 2 commits
March 15, 2024 11:39
… into deprecation/theme-color
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecation warning for color lightest and darkest
Related issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.