feat(action-menu): added static attribute support #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Tachometer resultsChromeaction-bar permalink
action-menu permalink
menu permalink
overlay permalink
picker permalink
popover permalink
split-button permalink
tooltip permalink
Firefoxaction-bar permalink
action-menu permalink
menu permalink
overlay permalink
picker permalink
popover permalink
split-button permalink
tooltip permalink
|
Rajdeepc
requested changes
Aug 23, 2023
…dobe/spectrum-web-components into blunteshwar/static-support-action-menu
Westbrook
suggested changes
Aug 23, 2023
Westbrook
reviewed
Aug 28, 2023
Westbrook
reviewed
Aug 29, 2023
|
|
||
| import '@spectrum-web-components/icons-workflow/icons/sp-icon-settings.js'; | ||
| import type { MenuItem } from '@spectrum-web-components/menu/src/MenuItem.js'; | ||
|
|
||
| export default { | ||
| component: 'sp-action-menu', | ||
| title: 'Action menu', | ||
| decorators: [makeOverBackground()], |
There was a problem hiding this comment.
Suggested change
| decorators: [makeOverBackground()], |
Changes updated. Let me know if you see any more issues here. |
Westbrook
approved these changes
Aug 30, 2023
blunteshwar
added a commit
that referenced
this pull request
Sep 12, 2023
* fix(action-menu): added static attribute support * fix(action-menu): replaced 'undefined' with 'none' * fix(action-menu): updated the tests * fix(action-menu): added golden hash key * fix(action-menu): added labels for control * fix: storybook none value maps to undefined * fix: storybook decorators reference for individual stories * chore: updated golden image cache --------- Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
staticattribute support for action-menuRelated issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.