fix(action-menu): added labels for control

adobe · Aug 23, 2023 · d0f8ae9 · d0f8ae9
1 parent 44e3588
commit d0f8ae9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/packages/action-menu/src/ActionMenu.ts b/packages/action-menu/src/ActionMenu.ts
@@ -44,7 +44,7 @@ export class ActionMenu extends ObserveSlotText(PickerBase, 'label') {
     public override selects: undefined | 'single' = undefined;
 
     @property({ type: String, reflect: true })
-    public static: 'white' | 'black' | 'none' = 'none';
+    public static: 'white' | 'black' | undefined = undefined;
 
     protected override listRole: 'listbox' | 'menu' = 'menu';
     protected override itemRole = 'menuitem';

diff --git a/packages/action-menu/stories/action-menu.stories.ts b/packages/action-menu/stories/action-menu.stories.ts
@@ -124,6 +124,11 @@ export default {
             },
             control: {
                 type: 'select',
+                labels: {
+                    white: 'white',
+                    black: 'black',
+                    none: undefined,
+                },
                 options: ['white', 'black', 'none'],
             },
         },
@@ -135,7 +140,7 @@ export default {
         quiet: false,
         tooltipDescription: '',
         tooltipPlacement: 'bottom',
-        static: 'none',
+        static: undefined,
     },
 };
 
@@ -147,7 +152,7 @@ interface StoryArgs {
     selects?: 'single';
     selected?: boolean;
     quiet?: boolean;
-    stati?: 'white' | 'black';
+    staticValue?: 'white' | 'black' | undefined;
     tooltipDescription?: string | 'none';
     tooltipPlacement?: string | 'none';
 }

diff --git a/packages/action-menu/test/index.ts b/packages/action-menu/test/index.ts
@@ -251,7 +251,7 @@ export const testActionMenu = (mode: 'sync' | 'async'): void => {
         it('can be `static`', async () => {
             const el = await actionMenuFixture();
 
-            expect(el.static == 'none').to.be.true;
+            expect(el.static == undefined).to.be.true;
 
             el.static = 'black';
             await elementUpdated(el);