Skip to content

Commit

Permalink
fix(slider): update slider config to process the tick css correctly (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
Rajdeepc authored Nov 8, 2024
1 parent a22f42b commit 7b1dfd0
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ executors:
parameters:
current_golden_images_hash:
type: string
default: 007d8fcc1444b5ba59b46fb123b09f97beca4b60
default: ea0db2c152ce09dc870edef573cd5e4a0bf44e60
wireit_cache_name:
type: string
default: wireit
Expand Down
46 changes: 46 additions & 0 deletions packages/slider/src/spectrum-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,52 @@ const config = {
converter.classToClass('spectrum-Slider-track', 'track'),
converter.classToClass('is-focused', 'handle-highlight'),
converter.classToClass('is-dragged', 'dragging'),
{
find: [
builder.class('spectrum-Slider-controls'),
{
type: 'pseudo-class',
kind: 'not',
selectors: [
[
{
type: 'pseudo-class',
kind: 'has',
selectors: [
[
builder.class(
'spectrum-Slider-ticks'
),
],
],
},
],
],
},
],
replace: [
{
replace: builder.id('controls'),
},
{
replace: {
kind: 'not',
type: 'pseudo-class',
selectors: [
[
{
type: 'pseudo-class',
kind: 'has',
selectors: [
[builder.class('ticks')],
],
},
],
],
},
},
],
},
{
find: [
// .spectrum-Slider-handle:before:dir(rtl)
Expand Down
2 changes: 1 addition & 1 deletion packages/slider/src/spectrum-slider.css
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ governing permissions and limitations under the License.
position: relative;
}

#controls:not(:has(.spectrum-Slider-ticks)) {
#controls:not(:has(.ticks)) {
align-items: center;
display: flex;
}
Expand Down

0 comments on commit 7b1dfd0

Please sign in to comment.