fix: improve accessibility through aria-label attribute usage

adobe · Oct 7, 2020 · 66752b7 · 66752b7
1 parent 7fce01c
commit 66752b7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/packages/bar-loader/src/BarLoader.ts b/packages/bar-loader/src/BarLoader.ts
@@ -91,5 +91,8 @@ export class BarLoader extends SpectrumElement {
         } else if (this.hasAttribute('aria-valuenow')) {
             this.removeAttribute('aria-valuenow');
         }
+        if (this.label && changes.has('label')) {
+            this.setAttribute('aria-label', this.label);
+        }
     }
 }
diff --git a/packages/circle-loader/src/CircleLoader.ts b/packages/circle-loader/src/CircleLoader.ts
@@ -30,6 +30,9 @@ export class CircleLoader extends SpectrumElement {
     @property({ type: Boolean, reflect: true })
     public indeterminate = false;
 
+    @property({ type: String })
+    public label = '';
+
     @property({ type: Boolean, reflect: true, attribute: 'over-background' })
     public overBackground = false;
 
@@ -86,5 +89,8 @@ export class CircleLoader extends SpectrumElement {
         } else if (this.hasAttribute('aria-valuenow')) {
             this.removeAttribute('aria-valuenow');
         }
+        if (this.label && changes.has('label')) {
+            this.setAttribute('aria-label', this.label);
+        }
     }
 }