fix(overlay): remove flex display for dialog (#4902)

adobe · Nov 11, 2024 · 48448ea · 48448ea
1 parent 5db0e7c
commit 48448ea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/packages/overlay/src/OverlayPopover.ts b/packages/overlay/src/OverlayPopover.ts
@@ -97,9 +97,7 @@ export function OverlayPopover<T extends Constructor<AbstractOverlay>>(
             });
         }
 
-        private async shouldShowPopover(
-            targetOpenState: boolean
-        ): Promise<void> {
+        private shouldShowPopover(targetOpenState: boolean): void {
             let popoverOpen = false;
             try {
                 popoverOpen = this.dialogEl.matches(':popover-open');
@@ -118,7 +116,7 @@ export function OverlayPopover<T extends Constructor<AbstractOverlay>>(
                 this.isConnected
             ) {
                 this.dialogEl.showPopover();
-                await this.managePosition();
+                this.managePosition();
             }
         }
 
@@ -129,7 +127,7 @@ export function OverlayPopover<T extends Constructor<AbstractOverlay>>(
             if (!supportsOverlayAuto) {
                 await this.shouldHidePopover(targetOpenState);
             }
-            await this.shouldShowPopover(targetOpenState);
+            this.shouldShowPopover(targetOpenState);
             await nextFrame();
         }
 

diff --git a/packages/overlay/src/overlay.css b/packages/overlay/src/overlay.css
@@ -39,7 +39,6 @@ governing permissions and limitations under the License.
     border: 0;
     background: none;
     padding: 0;
-    display: flex;
     position: fixed;
     overflow: visible;
     opacity: 1 !important;
@@ -180,7 +179,8 @@ slot[name='longpress-describedby-descriptor'] {
 @supports (overlay: auto) {
     .dialog {
         display: none;
-        transition: all
+        transition:
+            all
                 var(
                     --mod-overlay-animation-duration,
                     var(--spectrum-animation-duration-100, 0.13s)