fix: ensure "click" on "NumpadEnter" key press

adobe · Sep 20, 2021 · 450fa01 · 450fa01
1 parent e8d9768
commit 450fa01
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/packages/button/src/ButtonBase.ts b/packages/button/src/ButtonBase.ts
@@ -163,6 +163,7 @@ export class ButtonBase extends LikeAnchor(
         const { code } = event;
         switch (code) {
             case 'Enter':
+            case 'NumpadEnter':
                 this.click();
                 break;
             default:

diff --git a/packages/button/test/button.test.ts b/packages/button/test/button.test.ts
@@ -63,7 +63,7 @@ describe('Button', () => {
         await elementUpdated(el);
         expect(el).to.not.be.undefined;
         expect(el.textContent).to.include('Button');
-        expect(!((el as unknown) as { hasIcon: boolean }).hasIcon);
+        expect(!(el as unknown as { hasIcon: boolean }).hasIcon);
         await expect(el).to.be.accessible();
     });
     it('loads default only icon', async () => {
@@ -112,7 +112,7 @@ describe('Button', () => {
 
         await elementUpdated(el);
 
-        const labelTestableEl = (el as unknown) as TestableButtonType;
+        const labelTestableEl = el as unknown as TestableButtonType;
 
         expect(labelTestableEl.hasLabel, 'starts with label').to.be.true;
 
@@ -304,6 +304,20 @@ describe('Button', () => {
         expect(clickSpy.callCount).to.equal(1);
         clickSpy.resetHistory();
 
+        el.dispatchEvent(
+            new KeyboardEvent('keypress', {
+                bubbles: true,
+                composed: true,
+                cancelable: true,
+                code: 'NumpadEnter',
+                key: 'NumpadEnter',
+            })
+        );
+
+        await elementUpdated(el);
+        expect(clickSpy.callCount).to.equal(1);
+        clickSpy.resetHistory();
+
         el.dispatchEvent(
             new KeyboardEvent('keypress', {
                 bubbles: true,
@@ -451,9 +465,11 @@ describe('Button', () => {
         );
 
         await elementUpdated(el);
-        ((el as unknown) as {
-            anchorElement: HTMLAnchorElement;
-        }).anchorElement.addEventListener('click', (event: Event): void => {
+        (
+            el as unknown as {
+                anchorElement: HTMLAnchorElement;
+            }
+        ).anchorElement.addEventListener('click', (event: Event): void => {
             event.preventDefault();
             event.stopPropagation();
             clickSpy();