Merge pull request #250 from adobe/westbrook/243/tslib

perf: use imported TypeScript helpers instead of inlining them
adobe · Oct 10, 2019 · 1fd06fe · 1fd06fe
2 parents ec1d79c + 504c952
commit 1fd06fe
Show file tree

Hide file tree

Showing 36 changed files with 140 additions and 29 deletions.
diff --git a/__snapshots__/Lightest.md b/__snapshots__/Lightest.md
@@ -0,0 +1,7 @@
+# `Lightest`
+
+#### `loads`
+
+```html
+<slot></slot>
+```
diff --git a/__snapshots__/Themes.md b/__snapshots__/Themes.md
@@ -1,6 +1,6 @@
 # `Themes`
 
-#### `loads`
+#### `loads - light`
 
 ```html
 <sp-theme-light id="theme">
@@ -9,3 +9,19 @@
     </sp-scale-medium>
 </sp-theme-light>
 ```
+
+#### `loads - dark`
+
+```html
+<sp-theme-dark id="theme">
+    <sp-scale-medium id="scale">
+        <slot></slot>
+    </sp-scale-medium>
+</sp-theme-dark>
+```
+
+#### `loads - unkown`
+
+```html
+<slot></slot>
+```
diff --git a/karma.conf.js b/karma.conf.js
@@ -40,18 +40,10 @@ module.exports = (config) => {
             },
             coverageIstanbulReporter: {
                 // TODO(#212): reapply coverage based on source files.
-                // thresholds: {
-                //     global: {
-                //         statements: 94,
-                //         branches: 82,
-                //         functions: 96,
-                //         lines: 94,
-                //     },
-                // },
                 thresholds: {
                     global: {
-                        statements: 93,
-                        branches: 72,
+                        statements: 95,
+                        branches: 83,
                         functions: 96,
                         lines: 95,
                     },

diff --git a/packages/action-menu/package.json b/packages/action-menu/package.json
@@ -38,6 +38,7 @@
     "dependencies": {
         "@spectrum-web-components/dropdown": "^0.1.3",
         "@spectrum-web-components/menu": "^0.1.3",
-        "@spectrum-web-components/menu-item": "^0.1.3"
+        "@spectrum-web-components/menu-item": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/banner/package.json b/packages/banner/package.json
@@ -34,5 +34,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/bundle/package.json b/packages/bundle/package.json
@@ -65,6 +65,7 @@
         "@spectrum-web-components/tab-list": "^0.1.3",
         "@spectrum-web-components/textfield": "^0.1.3",
         "@spectrum-web-components/themes": "^0.1.3",
-        "@spectrum-web-components/tooltip": "^0.1.0"
+        "@spectrum-web-components/tooltip": "^0.1.0",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/button/package.json b/packages/button/package.json
@@ -36,6 +36,7 @@
         "lit-html": "^1.0.0"
     },
     "dependencies": {
-        "@spectrum-web-components/shared": "^0.1.3"
+        "@spectrum-web-components/shared": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/card/package.json b/packages/card/package.json
@@ -34,5 +34,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/checkbox/package.json b/packages/checkbox/package.json
@@ -38,6 +38,7 @@
     "dependencies": {
         "@spectrum-web-components/icon": "^0.1.3",
         "@spectrum-web-components/icons": "^0.1.3",
-        "@spectrum-web-components/shared": "^0.1.3"
+        "@spectrum-web-components/shared": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/dropdown/package.json b/packages/dropdown/package.json
@@ -42,6 +42,7 @@
         "@spectrum-web-components/menu": "^0.1.3",
         "@spectrum-web-components/menu-item": "^0.1.3",
         "@spectrum-web-components/popover": "^0.1.3",
-        "@spectrum-web-components/shared": "^0.1.3"
+        "@spectrum-web-components/shared": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/dropzone/package.json b/packages/dropzone/package.json
@@ -34,5 +34,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/icon/package.json b/packages/icon/package.json
@@ -36,6 +36,7 @@
         "lit-html": "^1.0.0"
     },
     "dependencies": {
-        "@spectrum-web-components/iconset": "^0.1.3"
+        "@spectrum-web-components/iconset": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/icons/package.json b/packages/icons/package.json
@@ -32,7 +32,8 @@
     "author": "",
     "license": "Apache-2.0",
     "dependencies": {
-        "@spectrum-web-components/iconset": "^0.1.3"
+        "@spectrum-web-components/iconset": "^0.1.3",
+        "tslib": "^1.10.0"
     },
     "peerDependencies": {
         "lit-element": "^2.1.0",

diff --git a/packages/iconset/package.json b/packages/iconset/package.json
@@ -32,5 +32,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/illustrated-message/package.json b/packages/illustrated-message/package.json
@@ -32,5 +32,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/link/package.json b/packages/link/package.json
@@ -32,5 +32,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/menu-group/package.json b/packages/menu-group/package.json
@@ -34,5 +34,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/menu-item/package.json b/packages/menu-item/package.json
@@ -39,6 +39,7 @@
         "@spectrum-web-components/button": "^0.1.3",
         "@spectrum-web-components/icon": "^0.1.3",
         "@spectrum-web-components/icons": "^0.1.3",
-        "@spectrum-web-components/shared": "^0.1.3"
+        "@spectrum-web-components/shared": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/menu/package.json b/packages/menu/package.json
@@ -34,5 +34,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/overlay-root/package.json b/packages/overlay-root/package.json
@@ -34,5 +34,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/overlay-trigger/package.json b/packages/overlay-trigger/package.json
@@ -36,6 +36,7 @@
         "lit-html": "^1.0.0"
     },
     "dependencies": {
-        "@spectrum-web-components/overlay-root": "^0.1.3"
+        "@spectrum-web-components/overlay-root": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/popover/package.json b/packages/popover/package.json
@@ -34,5 +34,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/radio-group/package.json b/packages/radio-group/package.json
@@ -36,6 +36,7 @@
         "lit-html": "^1.0.0"
     },
     "dependencies": {
-        "@spectrum-web-components/radio": "^0.1.3"
+        "@spectrum-web-components/radio": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/radio/package.json b/packages/radio/package.json
@@ -36,6 +36,7 @@
         "lit-html": "^1.0.0"
     },
     "dependencies": {
-        "@spectrum-web-components/shared": "^0.1.3"
+        "@spectrum-web-components/shared": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/shared/package.json b/packages/shared/package.json
@@ -34,5 +34,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/sidenav/package.json b/packages/sidenav/package.json
@@ -34,5 +34,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/slider/package.json b/packages/slider/package.json
@@ -36,6 +36,7 @@
         "lit-html": "^1.0.0"
     },
     "dependencies": {
-        "@spectrum-web-components/shared": "^0.1.3"
+        "@spectrum-web-components/shared": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/switch/package.json b/packages/switch/package.json
@@ -36,6 +36,7 @@
         "lit-html": "^1.0.0"
     },
     "dependencies": {
-        "@spectrum-web-components/checkbox": "^0.1.3"
+        "@spectrum-web-components/checkbox": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/tab-list/package.json b/packages/tab-list/package.json
@@ -34,5 +34,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/tab/package.json b/packages/tab/package.json
@@ -36,6 +36,7 @@
         "lit-html": "^1.0.0"
     },
     "dependencies": {
-        "@spectrum-web-components/shared": "^0.1.3"
+        "@spectrum-web-components/shared": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/textfield/package.json b/packages/textfield/package.json
@@ -38,6 +38,7 @@
     "dependencies": {
         "@spectrum-web-components/icon": "^0.1.3",
         "@spectrum-web-components/icons": "^0.1.3",
-        "@spectrum-web-components/shared": "^0.1.3"
+        "@spectrum-web-components/shared": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/themes/package.json b/packages/themes/package.json
@@ -36,6 +36,7 @@
         "lit-html": "^1.0.0"
     },
     "dependencies": {
-        "@spectrum-web-components/styles": "^0.1.3"
+        "@spectrum-web-components/styles": "^0.1.3",
+        "tslib": "^1.10.0"
     }
 }
diff --git a/packages/themes/test/themes.test.ts b/packages/themes/test/themes.test.ts
@@ -15,15 +15,52 @@ import { Theme } from '../';
 import { fixture, elementUpdated, html, expect } from '@open-wc/testing';
 
 describe('Themes', () => {
+    it('loads - light', async () => {
+        const el = await fixture<Theme>(
+            html`
+                <sp-theme color="light"></sp-theme>
+            `
+        );
+
+        await elementUpdated(el);
+
+        expect(el).shadowDom.to.equalSnapshot();
+    });
+    it('loads - dark', async () => {
+        const el = await fixture<Theme>(
+            html`
+                <sp-theme color="dark"></sp-theme>
+            `
+        );
+
+        await elementUpdated(el);
+
+        expect(el).shadowDom.to.equalSnapshot();
+    });
+    it('loads - unkown', async () => {
+        const el = await fixture<Theme>(
+            html`
+                <sp-theme color="unknown" scale="unknown"></sp-theme>
+            `
+        );
+
+        await elementUpdated(el);
+
+        expect(el).shadowDom.to.equalSnapshot();
+    });
+});
+
+describe('Lightest', () => {
     it('loads', async () => {
         const el = await fixture<Theme>(
             html`
-                <sp-Theme></sp-Theme>
+                <sp-theme-lightest></sp-theme-lightest>
             `
         );
 
         await elementUpdated(el);
 
+        expect(el).to.not.be.undefined;
         expect(el).shadowDom.to.equalSnapshot();
     });
 });
diff --git a/packages/tooltip/package.json b/packages/tooltip/package.json
@@ -31,5 +31,8 @@
     "peerDependencies": {
         "lit-element": "^2.1.0",
         "lit-html": "^1.0.0"
+    },
+    "dependencies": {
+        "tslib": "^1.10.0"
     }
 }
diff --git a/tsconfig.json b/tsconfig.json
@@ -11,6 +11,7 @@
         "noUnusedLocals": true,
         "target": "es2017",
         "skipLibCheck": true,
+        "importHelpers": true,
         "types": [
             "chai",
             "sinon",

diff --git a/yarn.lock b/yarn.lock
@@ -16570,7 +16570,7 @@ ts-simple-type@~0.3.5:
   resolved "https://registry.yarnpkg.com/ts-simple-type/-/ts-simple-type-0.3.6.tgz#aa5a107c420c3ebe9cf5de2fe426984d0f77c665"
   integrity sha512-dybO9ebUqOzldR5+SPP1uQSbxl/uiSIvjRC7dFuU45XE7H+4EoQMuxCFKoZj99qEo7pdDWSx52DEQAPZqL3SFg==
 
-tslib@^1.8.1, tslib@^1.9.0:
+tslib@^1.10.0, tslib@^1.8.1, tslib@^1.9.0:
   version "1.10.0"
   resolved "https://registry.yarnpkg.com/tslib/-/tslib-1.10.0.tgz#c3c19f95973fb0a62973fb09d90d961ee43e5c8a"
   integrity sha512-qOebF53frne81cf0S9B41ByenJ3/IuH8yJKngAX35CmiZySA0khhkovshKK+jGCaMnVomla7gVlIcc3EvKPbTQ==