fix: review feedback

adobe · Sep 20, 2024 · fb070a8 · fb070a8
1 parent 2d232aa
commit fb070a8
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 2 deletions.
diff --git a/...ecat-shared-rum-api-client/src/functions/opportunities/high-inorganic-high-bounce-rate.js b/...ecat-shared-rum-api-client/src/functions/opportunities/high-inorganic-high-bounce-rate.js
@@ -29,6 +29,7 @@ function convertToOpportunity(traffic) {
     screenshot: '',
     trackedPageKPIName: 'Bounce Rate',
     trackedPageKPIValue: bounceRate,
+    trackedKPISiteAverage: '',
     pageViews: total,
     samples: total, // todo: get the actual number of samples
     metrics: [{

diff --git a/packages/spacecat-shared-rum-api-client/src/functions/opportunities/high-organic-low-ctr.js b/packages/spacecat-shared-rum-api-client/src/functions/opportunities/high-organic-low-ctr.js
@@ -48,9 +48,9 @@ function convertToOpportunity(traffic) {
     screenshot: '',
     trackedPageKPIName: 'Click Through Rate',
     trackedPageKPIValue: ctr,
+    trackedKPISiteAverage: siteAvgCTR,
     pageViews: total,
     samples: total, // todo: get the actual number of samples
-    siteAverageCTR: siteAvgCTR,
     metrics: [{
       type: 'traffic',
       vendor: '*',

diff --git a/packages/spacecat-shared-rum-api-client/src/functions/opportunities/rageclick.js b/packages/spacecat-shared-rum-api-client/src/functions/opportunities/rageclick.js
@@ -118,6 +118,7 @@ function getRageClickOpportunities(rageClickInstances) {
       screenshot: '',
       trackedPageKPIName: OPPORTUNITY_DESCRIPTION,
       trackedPageKPIValue: '',
+      trackedKPISiteAverage: '',
       pageViews: rageClickInstances[url].pageViews,
       samples: rageClickInstances[url].samples,
       metrics: [],

diff --git a/packages/spacecat-shared-rum-api-client/test/fixtures/high-inorganic-high-bounce.json b/packages/spacecat-shared-rum-api-client/test/fixtures/high-inorganic-high-bounce.json
@@ -5,6 +5,7 @@
     "screenshot": "",
     "trackedPageKPIName": "Bounce Rate",
     "trackedPageKPIValue": 0.6507592190889371,
+    "trackedKPISiteAverage": "",
     "pageViews": 46100,
     "samples": 46100,
     "metrics": [
@@ -25,6 +26,7 @@
     "screenshot": "",
     "trackedPageKPIName": "Bounce Rate",
     "trackedPageKPIValue": 0.8723897911832946,
+    "trackedKPISiteAverage": "",
     "pageViews": 43100,
     "samples": 43100,
     "metrics": [

diff --git a/packages/spacecat-shared-rum-api-client/test/fixtures/high-organic-low-ctr.json b/packages/spacecat-shared-rum-api-client/test/fixtures/high-organic-low-ctr.json
@@ -7,7 +7,7 @@
     "trackedPageKPIValue": 0.14316702819956617,
     "pageViews": 46100,
     "samples": 46100,
-    "siteAverageCTR": 0.40828402366863903,
+    "trackedKPISiteAverage": 0.40828402366863903,
     "metrics": [
       {
         "type": "traffic",