Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STARTS_WITH/ENDS_WITH operators to StringRule #12

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

sic2
Copy link
Member

@sic2 sic2 commented Nov 14, 2024

Add STARTS_WITH/ENDS_WITH operators to StringRule

Description

This change add a couple of operators (STARTS_WITH, ENDS_WITH) to the StringRule.

Related Issue

None

Motivation and Context

This provides more expressiveness in the rules that can be created in Regola.

How Has This Been Tested?

Change tested via comphrensive unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sic2 sic2 requested a review from jetfreakk November 14, 2024 11:33
Copy link
Contributor

@jetfreakk jetfreakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the removal of SINGLE_FACT_OPERATORS from SIngleValueRule allows more flexibility and is helpful

@sic2 sic2 merged commit 89d55d5 into main Nov 14, 2024
2 checks passed
@sic2 sic2 deleted the feat/add_operations_to_string_rule branch November 14, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants