Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove iOS HiddenSelect workaround #7200

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Oct 15, 2024

Closes

Alternative to #7103

I have tried this out in iOS 18.0.1 and our hidden input isn't enabling the next/previous arrows which come with form filling anyways. So it doesn't really matter if it's removed.
We could also attempt to fix the behaviour for next/previous.

Can someone try the next/prev arrows in iOS 17? we suspect it wasn't working there already.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger changed the title Remove iOS HiddenSelect workaround fix: Remove iOS HiddenSelect workaround Oct 15, 2024
@rspbot
Copy link

rspbot commented Oct 16, 2024

@yihuiliao
Copy link
Member

not sure if i tested this correctly but this is what happens when i try using the next/prev arrows in a form. doesn't really seem to work too well for some of the components. i'm on iOS 17.6.1

RPReplay_Final1729122450.MP4

@snowystinger
Copy link
Member Author

not sure if i tested this correctly but this is what happens when i try using the next/prev arrows in a form. doesn't really seem to work too well for some of the components. i'm on iOS 17.6.1

@yihuiliao can you pop it out into a new tab? I found that works better. otherwise the iframe seems to interfere.

@yihuiliao
Copy link
Member

okay this is what's happening on main right now.

RPReplay_Final1729185605.MP4

i also briefly tested the next/prev arrows on this pr, same story, and it doesn't seem to be any different from what's happening on main

@snowystinger
Copy link
Member Author

@yihuiliao thank you for confirming. Next/Previous do skip over our Pickers/Selects

@snowystinger snowystinger mentioned this pull request Oct 17, 2024
5 tasks
@yihuiliao
Copy link
Member

yihuiliao commented Oct 31, 2024

Correct me if I'm wrong but is this the direction that we chose to go with at the end of otter time since it seems our support for the prev/next button has always been a bit finicky

devongovett
devongovett previously approved these changes Oct 31, 2024
Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop the mention of this feature from the docs for both RAC and hooks?

@rspbot
Copy link

rspbot commented Nov 1, 2024

@rspbot
Copy link

rspbot commented Nov 1, 2024

@snowystinger snowystinger added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit f256f0e Nov 1, 2024
30 checks passed
@snowystinger snowystinger deleted the remove-old-vhidden-workaround branch November 1, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants