-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove iOS HiddenSelect workaround #7200
Conversation
not sure if i tested this correctly but this is what happens when i try using the next/prev arrows in a form. doesn't really seem to work too well for some of the components. i'm on iOS 17.6.1 RPReplay_Final1729122450.MP4 |
@yihuiliao can you pop it out into a new tab? I found that works better. otherwise the iframe seems to interfere. |
okay this is what's happening on main right now. RPReplay_Final1729185605.MP4i also briefly tested the next/prev arrows on this pr, same story, and it doesn't seem to be any different from what's happening on main |
@yihuiliao thank you for confirming. Next/Previous do skip over our Pickers/Selects |
Correct me if I'm wrong but is this the direction that we chose to go with at the end of otter time since it seems our support for the prev/next button has always been a bit finicky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you drop the mention of this feature from the docs for both RAC and hooks?
Closes
Alternative to #7103
I have tried this out in iOS 18.0.1 and our hidden input isn't enabling the next/previous arrows which come with form filling anyways. So it doesn't really matter if it's removed.
We could also attempt to fix the behaviour for next/previous.
Can someone try the next/prev arrows in iOS 17? we suspect it wasn't working there already.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: