Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix tanstack router useHref example #7148

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

kveperedo
Copy link
Contributor

In the integration of the tanstack-router package in the docs, the router.buildLocation should accept an object instead in order for client-side routing to work as expected.

Reference:
https://github.com/TanStack/router/blob/main/packages/react-router/src/RouterProvider.tsx#L49

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr!

@yihuiliao yihuiliao changed the title fix tanstack router useHref example docs: fix tanstack router useHref example Oct 10, 2024
@yihuiliao yihuiliao added this pull request to the merge queue Oct 10, 2024
Merged via the queue into adobe:main with commit e9aa00a Oct 10, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants