Work around iOS 13 bug with pointer events #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! View the storybook |
| // Safari on iOS < 13.2 does not implement pointerenter/pointerleave events correctly. | ||
| // Use pointer move events instead to implement our own hit testing. | ||
| // See https://bugs.webkit.org/show_bug.cgi?id=199803 | ||
| let onPointerMove = (e: PointerEvent) => { |
There was a problem hiding this comment.
do we want to only use this for browsers that don't work correctly and use the onPointerEnter/Leave for the ones that are correct?
is there any easy way for us to actually check?
There was a problem hiding this comment.
I'm not really sure how we could detect it...
dannify
previously approved these changes
Nov 22, 2019
|
Build successful! View the storybook |
dannify
approved these changes
Nov 26, 2019
|
Build successful! View the storybook |
devongovett
added a commit
that referenced
this pull request
Jul 25, 2024
* Move Popover padding and add ref * Picker Dropdown using rainbow Popover * Prep for invalid state * review updates * Update picker styles to share menu * simplify grid * some API review * fix validation icon * Add missing types and functionality * add min width and quiet width handling * use a better minwidth for picker * fix isOpen style * review comments * fix placeholder and select value * fix textValue * fix crash in icons story * fix some invalid styles * Combobox (#100) * Combobox * Fix remaining ts issues * explain padding * Reviews * fix crash in icons story * apply same icon story crash fix from picker PR --------- Co-authored-by: Devon Govett <devongovett@gmail.com> Co-authored-by: danilu <danilu@adobe.com> --------- Co-authored-by: Devon Govett <devongovett@gmail.com> Co-authored-by: danilu <danilu@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: RSP-1383
iOS < 13.2 has a bug with pointer events where onPointerEnter and onPointerLeave are never called. This resulted in active state persisting after the user drags their touch out of the target. This PR works around it by registering a document level onPointerMove handler and doing our own hit testing, like we have already for touch events.