-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize docs build performance #5228
Changes from all commits
8d8e375
e37fa16
a67bda2
aa0ae19
50cd3c1
9d09974
f017634
dfab5df
89b6adc
7b562e4
dfae782
16ae68f
98c4750
057a391
8426d41
6132079
40e2a95
1aa2695
62b1d59
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,7 +54,7 @@ function Button<T extends ElementType = 'button'>(props: SpectrumButtonProps<T>, | |
props = useSlotProps(props, 'button'); | ||
props = disablePendingProps(props); | ||
let { | ||
elementType: ElementType = 'button', | ||
elementType: Element = 'button', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is to accommodate the docs generator. It was getting confused between |
||
children, | ||
variant, | ||
style = variant === 'accent' || variant === 'cta' ? 'fill' : 'outline', | ||
|
@@ -100,7 +100,7 @@ function Button<T extends ElementType = 'button'>(props: SpectrumButtonProps<T>, | |
|
||
return ( | ||
<FocusRing focusRingClass={classNames(styles, 'focus-ring')} autoFocus={autoFocus}> | ||
<ElementType | ||
<Element | ||
{...styleProps} | ||
{...mergeProps(buttonProps, hoverProps)} | ||
ref={domRef} | ||
|
@@ -143,7 +143,7 @@ function Button<T extends ElementType = 'button'>(props: SpectrumButtonProps<T>, | |
? <Text>{children}</Text> | ||
: children} | ||
</SlotProvider> | ||
</ElementType> | ||
</Element> | ||
</FocusRing> | ||
); | ||
} | ||
|
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why no terser update?