Table column resizing aria docs #3982

LFDanLu · 2023-01-31T01:06:11Z

Closes

✅ Pull Request Checklist:

Included link to corresponding React Spectrum GitHub Issue.
Added/updated unit tests and storybook for this change (for new code or code which already has tests).
Filled out test instructions.
Updated documentation (if it already exists for this component).
Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Looks at the column resizing docs for useTableState and useTable. In addition, try the styled example out here: https://codesandbox.io/s/objective-cherry-g837on?file=/src/App.tsx

🧢 Your Project:

RSP

…t/right arrows still a bit iffy, cant seem to get focus to move between the columns, def something with the menutrigger...

…umnResizeState

…e_docs

these are unecessary since the state returns the resizing column already and we have onResize handlers in useTableColumnResize

…trum into aria_table_docs

rspbot · 2023-01-31T01:14:31Z

Build successful! 🎉

packages/@react-aria/table/docs/useTable.mdx

rspbot · 2023-01-31T01:22:09Z

Build successful! 🎉

packages/@react-aria/table/docs/useTable.mdx

…o aria_table_docs

packages/@react-aria/table/docs/useTable.mdx

rspbot · 2023-01-31T01:54:21Z

Build successful! 🎉

packages/@react-stately/table/docs/useTableColumnResizeState.mdx

LFDanLu · 2023-03-31T00:10:08Z

TODO: update sandbox example so it uses input styles from useTableColumnResize hook instead of VisuallyHidden, need to wait for nightly/release for that

rspbot · 2023-03-31T00:13:17Z

Build successful! 🎉

rspbot · 2023-03-31T00:17:02Z

Build successful! 🎉

rspbot · 2023-04-05T18:43:17Z

Build successful! 🎉

rspbot · 2023-04-05T22:02:43Z

Build successful! 🎉

rspbot · 2023-04-05T22:12:45Z

Build successful! 🎉

rspbot · 2023-04-05T22:25:14Z

Build successful! 🎉

…o aria_table_docs

rspbot · 2023-04-05T22:33:46Z

Build successful! 🎉

rspbot · 2023-04-05T22:41:11Z

Build successful! 🎉

rspbot · 2023-04-05T22:41:13Z

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

LFDanLu added 16 commits January 24, 2023 17:22

progress for making aria table resizing example

dde2ec2

styling updates and addition of menu button for resizing

1057b99

fixing it so user doesnt focus the resizer immediately when using lef…

dd43fa4

…t/right arrows still a bit iffy, cant seem to get focus to move between the columns, def something with the menutrigger...

making column resize actually get called if provided

82c93d3

fixing bugs, testing various cases, adding description to useTableCol…

9d16cdd

…umnResizeState

Fix crash if onColumnResize is undef

f7693f1

figure out break

fa396c4

Merge branch 'main' of github.com:adobe/react-spectrum into aria_tabl…

620fbcb

…e_docs

fix docs build break, add rest of code

d6673f7

fix docs example render issues

77d58ca

remove onColumnResize/Start/End from useTableColumnResizeState

5f6fb07

these are unecessary since the state returns the resizing column already and we have onResize handlers in useTableColumnResize

Merge branch 'main' into fix_onColumnResize_call

4627c14

Merge branch 'fix_onColumnResize_call' of github.com:adobe/react-spec…

fb982c7

…trum into aria_table_docs

docs first draft

9cb87b3

remove local test story for now

b4775ae

Merge branch 'main' into aria_table_docs

e89bf58