Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for onMove events #3858

Merged
merged 5 commits into from
Jan 3, 2023
Merged

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Dec 16, 2022

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

To test this, the cursor should change in real-time as before. Indicating when you can resize in both directions or when you can resize only to the left or only to the right.
The cursor should only change for mouse, and should return to normal styles when keyboard is used to resize.
The blue line indicator of resizing should update as the resizing occurs and should also be on the currently resizing column.

🧢 Your Project:

@snowystinger snowystinger mentioned this pull request Dec 16, 2022
61 tasks
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well, confirmed that the resizer icon only appears when dragging with my mouse and not when using the keyboard. Also verified that the scrolling behavior when dragging past the edge of the table only happens when using keyboard and doesn't happen when resize is started via keyboard but then continued via mouse

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snowystinger snowystinger merged commit 080488a into main Jan 3, 2023
@snowystinger snowystinger deleted the simplify-column-resize-api branch January 3, 2023 23:22
@snowystinger snowystinger self-assigned this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants