Cancel press events on scroll #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
snowystinger
approved these changes
Mar 30, 2020
|
Build successful! 🎉 |
|
Build successful! 🎉 |
dannify
approved these changes
Apr 1, 2020
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When quickly scrolling a selectable list on iOS, sometimes it would close and select an item unexpectedly. This was caused by two issues:
onPointerUpeven when the touch isn't within the bounds of the element. This causes ouronPressUpevent to fire and select the item, closing the menu. It seemed to only happen after a long press before scrolling, or a very quick flick.onPointerCancelis usually fired when scrolling begins though. This is solved by checking if the coordinates of theonPointerUpevent are within the bounds of the item.onTouchEndwould still be fired even after scrolling. To fix this, we need to handleonScrolland cancel the press ourselves (pointer events do this by default).