-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sunburst #480
Open
JadenHowell
wants to merge
15
commits into
main
Choose a base branch
from
sunburst
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sunburst #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-480 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a POC for a Sunburst chart type. Spec builder for sunburst is hooked up and ready for a design review to determine if the API is good, and if the chart display matches spectrum design.
Motivation and Context
The sunburst chart type allows for a visualization similar to a donut chart, but with additional breakdown details. After about 4/5 layers deep it begins to be tough to read, but for low layer breakdowns in a circular format, the sunburst chart type is great.
How Has This Been Tested?
I have added tests for the sunburst spec builder and it's associated util files. I have also included a storybook with a simple, complex, with popovers, and with legend examples.
Screenshots (if appropriate):
Types of changes
Checklist: