Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunburst #480

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Sunburst #480

wants to merge 15 commits into from

Conversation

JadenHowell
Copy link
Contributor

Description

Creates a POC for a Sunburst chart type. Spec builder for sunburst is hooked up and ready for a design review to determine if the API is good, and if the chart display matches spectrum design.

Motivation and Context

The sunburst chart type allows for a visualization similar to a donut chart, but with additional breakdown details. After about 4/5 layers deep it begins to be tough to read, but for low layer breakdowns in a circular format, the sunburst chart type is great.

How Has This Been Tested?

I have added tests for the sunburst spec builder and it's associated util files. I have also included a storybook with a simple, complex, with popovers, and with legend examples.

Screenshots (if appropriate):

simple complex

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
68.5% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube Cloud

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant