Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All filterBy, SearchBy and Matches mathods should use Hamcreat matchers #157

Closed
baubakg opened this issue Aug 6, 2024 · 0 comments · Fixed by #158
Closed

All filterBy, SearchBy and Matches mathods should use Hamcreat matchers #157

baubakg opened this issue Aug 6, 2024 · 0 comments · Fixed by #158
Labels
enhancement New feature or request
Milestone
1.11.0

Comments

@baubakg
Copy link
Member

baubakg commented Aug 6, 2024

Previously all searches were based on equals. Instead we will use matchers to ensure that the the values are are correct.

This is an important task as it englobes:

  • StdLogEntry.matches
  • LogData.filterBy
  • LogData.searchBy
@baubakg baubakg added the enhancement New feature or request label Aug 6, 2024
@baubakg baubakg added this to the 1.11.0 milestone Aug 6, 2024
baubakg added a commit that referenced this issue Aug 6, 2024
@baubakg
Fixed #154 and issue #157 : added enrichment, also replaced the use o…
70d6111 
…f Map<String, Object> <ith Map<String, Matcher> for all search methods
@baubakg baubakg mentioned this issue Aug 6, 2024
Merged
10 tasks
@baubakg baubakg linked a pull request Aug 6, 2024 that will close this issue
154 provide an enrich functionality #158
Merged
10 tasks
baubakg added a commit that referenced this issue Aug 6, 2024
@baubakg
#157 : solved issue with emty search criteria
5b77583
baubakg added a commit that referenced this issue Aug 6, 2024
@baubakg
154 provide an enrich functionality (#158)
80d9b67 
* Fixed #154  : added enrichment,
* Fixed  issue #157 : all search modes now use a Map<String, Matcher>
* Updating hamcrest librarires
* #154 added test for enrichment in SDK, and corrected the test SDK
* #154 added the enrichEmpty method
This was referenced Aug 7, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.11.0
Development

Successfully merging a pull request may close this issue.

154 provide an enrich functionality adobe/log-parser
1 participant
@baubakg