-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for base64 images #154
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
- Coverage 97.66% 95.66% -2.00%
==========================================
Files 21 14 -7
Lines 1800 1547 -253
==========================================
- Hits 1758 1480 -278
- Misses 42 67 +25 ☔ View full report in Codecov by Sentry. |
aa9615c
to
893d427
Compare
@kptdobe, should this implementation support |
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Context
Contribution following code sample shared with customer to solve the issue on a specific project.
What it does
preprocess
function.Then, base64 images were removed
Now, original base64 images are modified: the base64 inline data is replaced by an object URL (generated using https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL_static)
How to test
issue-28
hlx import
to fetch latesthelix-importer-ui
then stop it already.tools/importer/helix-importer-ui/
:package.json
modify helix-importer dependency toadobe/helix-importer#feat-support-b64-images
rm node_modules
npm install
npm run build:dev
helix-importer-ui
project,hlx import --skip-ui
https://www.petplace.com/article/breed/pembroke-welsh-corgi/
http://localhost:3001/tools/importer/import.js