Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exclude background-image none from DOM #291

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Nov 1, 2023

background-image styles are inlined in style attribute in the DOM so that they are available during the import process (could be "content" image coming from the CSS). The current logic inline the background-image even if it is none: this is useless and pollutes the HTML for nothing.

@kptdobe kptdobe requested a review from catalan-adobe November 1, 2023 13:16
@kptdobe kptdobe merged commit 8dbfd5a into main Nov 1, 2023
2 checks passed
@kptdobe kptdobe deleted the remove-background-image-pollution branch November 1, 2023 15:13
github-actions bot pushed a commit that referenced this pull request Nov 1, 2023
# [1.48.0](v1.47.5...v1.48.0) (2023-11-01)

### Features

* exclude background-image none from DOM ([#291](#291)) ([8dbfd5a](8dbfd5a))
Copy link

github-actions bot commented Nov 1, 2023

🎉 This PR is included in version 1.48.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants