feat(sites-29416)!: Add support for importing non-image assets #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should use lower case for the asset folder names, since in AEM DAM paths are case-sensitive; AEM automatically generates a JCR node name that is lowercased, so reference paths should also use lower case.
This reverts commit cdc8b74.
Merged
10 tasks
bhellema
reviewed
Feb 26, 2025
| @@ -10,9 +10,9 @@ | |||
| * governing permissions and limitations under the License. | |||
| */ | |||
| import { createJcrPackage } from './package/packaging.js'; | |||
| import { getImageUrlsFromMarkdown } from './package/image-mapping.js'; | |||
| import { getAssetUrlsFromMarkdown } from './package/asset-mapping.js'; | |||
There was a problem hiding this comment.
requires a full version bump when releasing!
| @@ -18,6 +18,9 @@ const imageRegex = /!\[([^\]]*)]\(([^) "]+)(?: *"([^"]*)")?\)|!\[([^\]]*)]\[([^\ | |||
| // Regex for reference definitions | |||
| const referenceRegex = /\[([^\]]+)]:\s*(\S+)/g; | |||
|
|
|||
| // Regex for non-image asset links (PDFs, docs, excel etc.) | |||
| const nonImageAssetRegex = /(?:\[(.*?)\]|\[.*?\])\(([^)]+\.(?:pdf|doc|docx|xls|xlsx|ppt|pptx|odt|ods|odp|rtf|txt|csv))\)|\[(.*?)\]:\s*(\S+\.(?:pdf|doc|docx|xls|xlsx|ppt|pptx|odt|ods|odp|rtf|txt|csv))/gi; | |||
There was a problem hiding this comment.
We need a unit test to validate that we are catching the different types of assets.
ManasMaji
changed the title
ManasMaji
changed the title
bhellema
changed the title
bhellema
approved these changes
Feb 26, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
# [2.0.0](v1.1.2...v2.0.0) (2025-02-26) * feat(sites-29416)!: Add support for importing non-image assets ([#7](#7)) ([ef4b444](ef4b444)) ### BREAKING CHANGES * The API getImageUrlsFromMarkdown has been renamed to getAssetUrlsFromMarkdown, to align more accurately to what it is doing. Co-authored-by: Ben Helleman <bhellema@adobe.com>
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the importer to also import non-image assets that are linked in the page : pdf | doc | excel | videos
SITES-29416
Motivation and Context
To allow users to import all type of assets to AEM for Crosswalk use case.
BREAKING CHANGE: The API getImageUrlsFromMarkdown has been renamed to getAssetUrlsFromMarkdown, to align more accurately to what it is doing.