Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add numeric icon feature #762

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add numeric icon feature #762

wants to merge 1 commit into from

Conversation

dkuntze
Copy link
Collaborator

@dkuntze dkuntze commented Dec 2, 2024

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

This PR expands the ability to have numbers in icon names while keeping existing functionality. It does fail the regex vulnerability check at https://devina.io/redos-checker (but so does the existing). Will look at seeing if its possible to refactor to make it free of vulnerabilities by making this a tokenizer statemachine.

Related Issues

Thanks for contributing!

@dkuntze dkuntze requested a review from tripodsan December 2, 2024 16:03
@dkuntze dkuntze marked this pull request as ready for review December 2, 2024 16:03
Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, but we need to do a full scan of all content of all customers in order to judge the scope of this change. the last time, we created a CSO with exactly this kind of fix.

@alexcarol
Copy link

This will also be useful for the ESRI project, thanks @dkuntze!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants