Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static html from the code bus with selectors no longer works #481

Closed
shsteimer opened this issue Jan 2, 2024 · 4 comments
Closed

static html from the code bus with selectors no longer works #481

shsteimer opened this issue Jan 2, 2024 · 4 comments
Assignees
Labels
bug Something isn't working released on @5.x released

Comments

@shsteimer
Copy link

Description
Due to recent changes #471 static html served via the cod bus that contains a selector fails to load with a 404

To Reproduce
Steps to reproduce the behavior:

  1. add a static html file to code bus with a selector, something like /blocks/my-block/my-block.selector.html
  2. attempt to access that file
  3. see 404 response with invalid path error

Expected behavior
static html should be served as expected

Version:
run: $ hlx --version

Additional context
See thread with customer at https://adobe-dx-support.slack.com/archives/C03GXBSC72T/p1704214470859999

they are fixing on their side to work around regression, so unsure if we must fix this or not. But I do think we should at least try to make sure the cli behaves the same to avoid customer confusion

@shsteimer shsteimer added the bug Something isn't working label Jan 2, 2024
@shsteimer
Copy link
Author

Looking into this a bit more, I think what happened is that these requests never used to make it to this service? Now that they do, they are failing the path info checks.

I think the path info check could be simplified to just:

 // only support selectors with html
  if (info.selector) {
    return info.extension === '.html';
  }

but that would require changing a few other tests to match that expectation.

@tripodsan curious for your thoughts.

@tripodsan
Copy link
Contributor

fixed

github-actions bot pushed a commit that referenced this issue Jan 29, 2024
## [5.6.1](v5.6.0...v5.6.1) (2024-01-29)

### Bug Fixes

* allow static html with selectors ([#510](#510)) ([26533a2](26533a2)), closes [#481](#481)
Copy link

🎉 This issue has been resolved in version 5.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

tripodsan added a commit that referenced this issue Feb 9, 2024
github-actions bot pushed a commit that referenced this issue Feb 9, 2024
# [6.5.0](v6.4.1...v6.5.0) (2024-02-09)

### Bug Fixes

* allow static html with selectors ([#510](#510)) ([91e20a1](91e20a1)), closes [#481](#481)

### Features

* remove source-location surrogate key ([049caf0](049caf0))
Copy link

github-actions bot commented Feb 9, 2024

🎉 This issue has been resolved in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released on @5.x released
Projects
None yet
Development

No branches or pull requests

2 participants