-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static html from the code bus with selectors no longer works #481
Comments
Looking into this a bit more, I think what happened is that these requests never used to make it to this service? Now that they do, they are failing the path info checks. I think the path info check could be simplified to just:
but that would require changing a few other tests to match that expectation. @tripodsan curious for your thoughts. |
fixed |
🎉 This issue has been resolved in version 5.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Due to recent changes #471 static html served via the cod bus that contains a selector fails to load with a 404
To Reproduce
Steps to reproduce the behavior:
/blocks/my-block/my-block.selector.html
invalid path
errorExpected behavior
static html should be served as expected
Version:
run:
$ hlx --version
Additional context
See thread with customer at https://adobe-dx-support.slack.com/archives/C03GXBSC72T/p1704214470859999
they are fixing on their side to work around regression, so unsure if we must fix this or not. But I do think we should at least try to make sure the cli behaves the same to avoid customer confusion
The text was updated successfully, but these errors were encountered: