Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragment redirects not working as expected #451

Closed
rofe opened this issue Nov 9, 2023 · 1 comment · Fixed by #452
Closed

Fragment redirects not working as expected #451

rofe opened this issue Nov 9, 2023 · 1 comment · Fixed by #452
Assignees
@tripodsan
Labels
bug Something isn't working released

Comments

@rofe
Copy link
Contributor

rofe commented Nov 9, 2023

Description
Fragment redirects end up on the main resource URL instead of the .plain.html one.

To Reproduce
Steps to reproduce the behavior:

  1. Define a redirect: from /foo to /bar
  2. Request /foo.plain.html
  3. The redirect sends you to /bar

Expected behavior
The redirect keeps the suffix and sends you to /bar.plain.html
@rofe rofe added the bug Something isn't working label Nov 9, 2023
@tripodsan tripodsan self-assigned this Nov 9, 2023
tripodsan added a commit that referenced this issue Nov 9, 2023
@tripodsan
fix: append .plain.html in redirects if needed
66aa0ff 
fixes #451
@tripodsan tripodsan mentioned this issue Nov 9, 2023
Merged
tripodsan added a commit that referenced this issue Nov 9, 2023
@tripodsan
fix: append .plain.html in redirects if needed (#452)
d3035a1 
fixes #451
github-actions bot pushed a commit that referenced this issue Nov 9, 2023
@semantic-release-bot
chore(release): 5.1.1 [skip ci]
611c4d4 
## [5.1.1](v5.1.0...v5.1.1) (2023-11-09)

### Bug Fixes

* append .plain.html in redirects if needed ([#452](#452)) ([d3035a1](d3035a1)), closes [#451](#451)
* increase test time ([336bda0](336bda0))
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

🎉 This issue has been resolved in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: append .plain.html in redirects if needed adobe/helix-html-pipeline
2 participants
@tripodsan @rofe