Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images are no longer absolute #405

Closed
dominique-pfister opened this issue Sep 21, 2023 · 1 comment · Fixed by #406
Closed

images are no longer absolute #405

dominique-pfister opened this issue Sep 21, 2023 · 1 comment · Fixed by #406
Assignees
@tripodsan
Labels
bug Something isn't working released

Comments

@dominique-pfister
Copy link
Contributor

dominique-pfister commented Sep 21, 2023 •
edited
Loading

An image that used to be written like this in the .md:

https://main--moleculardevices--hlxsites.hlx.page/media_176cf630873d24a275d9f500a15fd32abca5be225.jpeg#width=350&height=200

and had a production CDN prefix in the og:image tag, now suddenly is relative in the HTML:

<meta property="og:image" content="./media_176cf630873d24a275d9f500a15fd32abca5be225.jpeg?width=750&#x26;format=jpeg&#x26;optimize=medium">
@dominique-pfister dominique-pfister added the bug Something isn't working label Sep 21, 2023
tripodsan added a commit that referenced this issue Sep 21, 2023
@tripodsan
fix: properly rewrite meta image
4c91e5a 
fixes #405
@tripodsan tripodsan mentioned this issue Sep 21, 2023
Merged
tripodsan added a commit that referenced this issue Sep 21, 2023
@tripodsan
fix: properly rewrite meta image (#406)
d0c173f 
fixes #405
github-actions bot pushed a commit that referenced this issue Sep 21, 2023
@semantic-release-bot
chore(release): 5.0.3 [skip ci]
b798d2b 
## [5.0.3](v5.0.2...v5.0.3) (2023-09-21)

### Bug Fixes

* properly rewrite meta image ([#406](#406)) ([d0c173f](d0c173f)), closes [#405](#405)
@github-actions
Copy link

🎉 This issue has been resolved in version 5.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: properly rewrite meta image adobe/helix-html-pipeline
2 participants
@tripodsan @dominique-pfister