skip rewrite-icons for certain conditions

[maxakuru]

The current behavior for icons is to rewrite any text that matches /:(#?[a-z_-]+[a-z\d]*):/gi with a span

Problem: this replaces strings that intentionally use colons inside them, like URNs

There are a couple cases I think this could be avoided without being too much of an impact:

1. inside code elements

• I would argue it's unlikely authors intend to insert icons inside code blocks, at least when being used for code
• this would match github/slack functionality, eg. 👍 :+1:

2. inside urns/hrefs

• URNs may exist in content
• some links contain URNs or path segments that resemble URNs, eg. sharepoint
• unlikely icons are intentionally inserted into those patterns
  • (?<!(?:https?|urn)[^\s]*):(#?[a-z_-]+[a-z\d]*):
  • can't begin with urn:, http: or https:

[maxakuru]

this would technically be a breaking change, but not sure how often each case might be relied on right now

wdyt @tripodsan @trieloff @dominique-pfister ?

[tripodsan]

I think this is ok. @davidnuescheler should decide :-)

[bstopp]

What about not processing unless they are terminated by spaces? or that are at word boundaries? (Trying to determine how to still process when it's the only content, but not if it's in contiguous content.

/\b:(#?[a-z_-]+[a-z\d]*):\b/gi

[maxakuru]

@bstopp I think that is contrary to what people are used to in places like slack or:rocket:github, which is nice to stick close to for icons imo

for URNs I think case 2 could just be adjusted to include urn: as an ignored scheme along with https?:

[github-actions]

🎉 This issue has been resolved in version 4.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 3.11.22 🎉

The release is available on:

• npm package (@release-3.x dist-tag)
• GitHub release

Your semantic-release bot 📦🚀