Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove type attribute from img tag #330

Merged
merged 1 commit into from
Jun 7, 2023
Merged

fix: remove type attribute from img tag #330

merged 1 commit into from
Jun 7, 2023

Conversation

tripodsan
Copy link
Contributor

fixes #319

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

This PR will trigger a patch release when merged.

@tripodsan tripodsan requested review from rofe and davidnuescheler June 3, 2023 08:54
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #330 (f4e9d4b) into main (c7100ef) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #330   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           52        52           
  Lines         4288      4288           
=========================================
  Hits          4288      4288
Impacted Files Coverage Δ
src/steps/create-pictures.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

davidnuescheler
davidnuescheler approved these changes Jun 6, 2023
View reviewed changes
Copy link

@davidnuescheler davidnuescheler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Can we quickly make sure that the top 5 projects don't have any unexpected impact?

@tripodsan tripodsan merged commit 0272ea8 into main Jun 7, 2023
@tripodsan tripodsan deleted the remove-type branch June 7, 2023 07:53
github-actions bot pushed a commit that referenced this pull request Jun 7, 2023
@semantic-release-bot
chore(release): 3.11.13 [skip ci]
a4e8e56 
## [3.11.13](v3.11.12...v3.11.13) (2023-06-07)

### Bug Fixes

* remove type attribute from img tag ([#330](#330)) ([0272ea8](0272ea8)), closes [#319](#319)
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

🎉 This PR is included in version 3.11.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidnuescheler davidnuescheler davidnuescheler approved these changes

@rofe rofe rofe approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

img tag should not have a type attribute
3 participants
@tripodsan @rofe @davidnuescheler