Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

img tag should not have a type attribute #319

Closed
rofe opened this issue May 23, 2023 · 1 comment · Fixed by #330
Closed

img tag should not have a type attribute #319

rofe opened this issue May 23, 2023 · 1 comment · Fixed by #330
Assignees
@tripodsan
Labels
bug Something isn't working released

Comments

@rofe
Copy link
Contributor

rofe commented May 23, 2023

Description
From validator.w3.org:

Attribute type not allowed on element img at this point.

To Reproduce
https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.hlx.live%2F

Expected behavior
No type attribute on img tags.
@rofe rofe added the bug Something isn't working label May 23, 2023
@tripodsan tripodsan changed the title img tag should not have a type attribute` img tag should not have a type attribute May 23, 2023
@tripodsan tripodsan self-assigned this Jun 3, 2023
tripodsan added a commit that referenced this issue Jun 3, 2023
@tripodsan
fix: remove type attribute from img tag
f4e9d4b 
fixes #319
@tripodsan tripodsan mentioned this issue Jun 3, 2023
Merged
tripodsan added a commit that referenced this issue Jun 7, 2023
@tripodsan
fix: remove type attribute from img tag (#330)
0272ea8 
fixes #319
github-actions bot pushed a commit that referenced this issue Jun 7, 2023
@semantic-release-bot
chore(release): 3.11.13 [skip ci]
a4e8e56 
## [3.11.13](v3.11.12...v3.11.13) (2023-06-07)

### Bug Fixes

* remove type attribute from img tag ([#330](#330)) ([0272ea8](0272ea8)), closes [#319](#319)
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

🎉 This issue has been resolved in version 3.11.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove type attribute from img tag adobe/helix-html-pipeline
2 participants
@tripodsan @rofe