Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't rewrite production URLs anymore #165

Closed
tripodsan opened this issue Oct 21, 2022 · 1 comment · Fixed by #175
Closed

don't rewrite production URLs anymore #165

tripodsan opened this issue Oct 21, 2022 · 1 comment · Fixed by #175
Assignees
@tripodsan
Labels
bug Something isn't working released

Comments

@tripodsan
Copy link
Contributor

tripodsan commented Oct 21, 2022 •
edited
Loading

Description
rewriting production urls is more of a problem than a feature, especially when migrating to different sites.

suggestion

only rewrite *.hlx.page and *.hlx.live url in links and images.
@tripodsan tripodsan added the bug Something isn't working label Oct 21, 2022
@tripodsan tripodsan self-assigned this Oct 29, 2022
tripodsan added a commit that referenced this issue Oct 29, 2022
@tripodsan
fix: don't rewrite production urls
2450ec3 
fixes #165
@tripodsan tripodsan mentioned this issue Oct 29, 2022
Merged
github-actions bot pushed a commit that referenced this issue Oct 31, 2022
@semantic-release-bot
chore(release): 3.6.1 [skip ci]
2d1ea2c 
## [3.6.1](v3.6.0...v3.6.1) (2022-10-31)

### Bug Fixes

* don't rewrite production urls ([#175](#175)) ([815c154](815c154)), closes [#165](#165)
@github-actions
Copy link

🎉 This issue has been resolved in version 3.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't rewrite production urls adobe/helix-html-pipeline
1 participant
@tripodsan