Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link rewrite doesn't work for root urls w/o slash #161

Closed
tripodsan opened this issue Oct 11, 2022 · 1 comment
Closed

link rewrite doesn't work for root urls w/o slash #161

tripodsan opened this issue Oct 11, 2022 · 1 comment
Labels
bug Something isn't working released

Comments

@tripodsan
Copy link
Contributor

the link rewriter does not seem to accept https://main--birdiesforthebrave--hlxsites.hlx.page as a valid link target, it needs to be https://main--birdiesforthebrave--hlxsites.hlx.page/ (with trailing slash)
@tripodsan tripodsan added the bug Something isn't working label Oct 11, 2022
trieloff added a commit that referenced this issue Oct 14, 2022
@trieloff
test(utils): add test for #161
ab820b8
@trieloff trieloff mentioned this issue Oct 14, 2022
Merged
github-actions bot pushed a commit that referenced this issue Oct 17, 2022
@semantic-release-bot
chore(release): 3.4.5 [skip ci]
8c11737 
## [3.4.5](v3.4.4...v3.4.5) (2022-10-17)

### Bug Fixes

* **utils:** do not rewrite links to www or admin ([5239749](5239749)), closes [#145](#145)
* **utils:** fix undefined reference in rewriteLinks ([a6b5dd0](a6b5dd0))
* **utils:** rewrite helix links without a trailing slash ([8dc1e35](8dc1e35)), closes [#161](#161)
@github-actions
Copy link

🎉 This issue has been resolved in version 3.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tripodsan