Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if redirects also send custom headers #153

Closed
tripodsan opened this issue Oct 5, 2022 · 4 comments · Fixed by #154 or #158
Closed

check if redirects also send custom headers #153

tripodsan opened this issue Oct 5, 2022 · 4 comments · Fixed by #154 or #158
Labels
bug Something isn't working released on @1.x released

Comments

@tripodsan
Copy link
Contributor

Description
from slack:

I think it works fine if it wasn't 301. let me check..

Unfortunately the pipeline will not return your response headers with the 301 as it stands today.
@tripodsan tripodsan added the bug Something isn't working label Oct 5, 2022
trieloff added a commit that referenced this issue Oct 5, 2022
@trieloff
fix(html): do not skip custom headers for 3xx responses
9f7765d 
fixes #153
@trieloff trieloff mentioned this issue Oct 5, 2022
Merged
@seanchoi-dev
Copy link

Here is slack thread: https://adobe-mwp.slack.com/archives/C9KD0TT6G/p1664925181924599
Here are some of many broken pages:

tripodsan pushed a commit that referenced this issue Oct 6, 2022
@trieloff
fix(html): do not skip custom headers for 3xx responses
5aebe7a 
fixes #153
github-actions bot pushed a commit that referenced this issue Oct 6, 2022
@semantic-release-bot
chore(release): 3.4.3 [skip ci]
25b963b 
## [3.4.3](v3.4.2...v3.4.3) (2022-10-06)

### Bug Fixes

* **html:** do not skip custom headers for 3xx responses ([5aebe7a](5aebe7a)), closes [#153](#153)
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

🎉 This issue has been resolved in version 3.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

tripodsan pushed a commit that referenced this issue Oct 6, 2022
@trieloff @tripodsan
fix(html): do not skip custom headers for 3xx responses
666bee0 
fixes #153
@tripodsan tripodsan mentioned this issue Oct 6, 2022
Merged
tripodsan added a commit that referenced this issue Oct 6, 2022
@tripodsan
fix(html): do not skip custom headers for 3xx responses
bec1b7c 
fixes #153
@tripodsan tripodsan mentioned this issue Oct 6, 2022
Merged
tripodsan added a commit that referenced this issue Oct 6, 2022
@tripodsan
fix(html): do not skip custom headers for 3xx responses (json)
396f3f4 
fixes #153
github-actions bot pushed a commit that referenced this issue Oct 6, 2022
@semantic-release-bot
chore(release): 1.8.3 [skip ci]
cf9f87f 
## [1.8.3](v1.8.2...v1.8.3) (2022-10-06)

### Bug Fixes

* **html:** do not skip custom headers for 3xx responses (json) ([396f3f4](396f3f4)), closes [#153](#153)
tripodsan added a commit that referenced this issue Oct 6, 2022
@tripodsan
fix(html): do not skip custom headers for 3xx responses (json)
7dfd60d 
fixes #153
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

🎉 This issue has been resolved in version 1.8.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Oct 6, 2022
@semantic-release-bot
chore(release): 3.4.4 [skip ci]
25b895e 
## [3.4.4](v3.4.3...v3.4.4) (2022-10-06)

### Bug Fixes

* **html:** do not skip custom headers for 3xx responses (json) ([7dfd60d](7dfd60d)), closes [#153](#153)
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

🎉 This issue has been resolved in version 3.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released on @1.x released
Projects
None yet
Milestone
No milestone
2 participants
@tripodsan @seanchoi-dev