fix: check for state.info (#779)

fixes #778
adobe · Jan 1, 2025 · 57a1818 · 57a1818
1 parent 927631c
commit 57a1818
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/forms-pipe.js b/src/forms-pipe.js
@@ -108,6 +108,11 @@ export async function formsPipe(state, req) {
     res.headers.set('x-error', 'contentBusId missing');
     return res;
   }
+  if (!state.info) {
+    res.status = 400;
+    res.headers.set('x-error', 'no valid path');
+    return res;
+  }
 
   await fetchConfigAll(state, req, res);
   await authenticate(state, req, res);

diff --git a/test/forms-pipe.test.js b/test/forms-pipe.test.js
@@ -276,6 +276,22 @@ describe('Form POST Requests', () => {
     assert.strictEqual(resp.status, 405);
   });
 
+  it('POST request with trailing dot', async () => {
+    const req = new PipelineRequest('https://helix-pipeline.com/', defaultRequest);
+    const state = new PipelineState({
+      owner: 'owner',
+      repo: 'repo',
+      ref: 'ref',
+      partition: 'live',
+      path: '/somepath/.',
+      log: console,
+      s3Loader: mockHelixConfig(new StaticS3Loader()),
+    });
+
+    const resp = await formsPipe(state, req);
+    assert.strictEqual(resp.status, 400);
+  });
+
   it('no post body', async () => {
     const req = new PipelineRequest('https://helix-pipeline.com/', {
       ...defaultRequest,