Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deal with node v19 breaking change (keep-alive enabled on global agent) #478

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

stefan-guggisberg
Copy link
Contributor

Related Issues

#472

src/core/h1.js Outdated Show resolved Hide resolved
Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the typo in the comment.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3bfc9a6) to head (a659d4a).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #478   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         3270      3296   +26     
=========================================
+ Hits          3270      3296   +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 7, 2024

This PR will trigger a patch release when merged.

@stefan-guggisberg stefan-guggisberg merged commit 89d982d into main Jun 7, 2024
6 checks passed
@stefan-guggisberg stefan-guggisberg deleted the issue-472 branch June 7, 2024 08:44
github-actions bot pushed a commit that referenced this pull request Jun 7, 2024
## [4.1.8](v4.1.7...v4.1.8) (2024-06-07)

### Bug Fixes

* deal with node v19 breaking change (keep-alive enabled on global agent) ([#478](#478)) ([89d982d](89d982d))
Copy link

github-actions bot commented Jun 7, 2024

🎉 This PR is included in version 4.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants