Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-79 Copy and delete performance #90

Closed
wants to merge 2 commits into from
Closed

GH-79 Copy and delete performance #90

wants to merge 2 commits into from

Conversation

bstopp
Copy link
Contributor

@bstopp bstopp commented Oct 29, 2024

Description

Copy & Delete now return a specific status code based on resulting state:

  • 204 if the operation is complete
  • 206 if there is more to process.

Copy Operation will return a list of remaining Keys that need to be updated. If present, will not query system again, will just operate on the list. If still more remain after sub-process limit is reached, repeat the call via client.

Delete operation can simply be called again and again until a 204 response is returned.

Related Issue

Fixes #79

How Has This Been Tested?

Added unit tests, also added functional/integration test as expected by browser.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 86.76471% with 9 lines in your changes missing coverage. Please review.

Project coverage is 56.17%. Comparing base (e407d91) to head (68d45f1).

Files with missing lines Patch % Lines
src/helpers/copy.js 0.00% 5 Missing ⚠️
src/storage/object/delete.js 88.57% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   53.64%   56.17%   +2.52%     
==========================================
  Files          38       38              
  Lines        1795     1821      +26     
==========================================
+ Hits          963     1023      +60     
+ Misses        832      798      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bstopp bstopp requested a review from bosschaert October 31, 2024 14:12
@bstopp bstopp closed this Oct 31, 2024
@bstopp bstopp deleted the copy-perf-redux branch October 31, 2024 16:54
@bstopp bstopp restored the copy-perf-redux branch October 31, 2024 16:54
@bstopp bstopp deleted the copy-perf-redux branch November 1, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve copy and delete performance
2 participants