This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Disable File Watchers on XP (For real this time) #7170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterflynn this is ready for your review |
| @@ -149,6 +149,13 @@ define(function (require, exports, module) { | |||
| } | |||
|
|
|||
| /** | |||
| * Determines if we're running on Windows XP | |||
| */ | |||
| function _isRunningOnWindowsXP() { | |||
There was a problem hiding this comment.
Drive-by: could just figure this out once on startup and store it in a var
There was a problem hiding this comment.
True, and watchPath() will get called once per folder on Linux -- though I don't expect this to be any sort of perf botleneck. Seems reasonable to make the change though given that it's static information.
|
@JeffryBooher Done reviewing. Looks good other than those minor nits. |
|
Tagged sprint 37 |
|
All changes made. I think it's ready for merging. |
|
Looks great! |
peterflynn
added a commit
that referenced
this pull request
Mar 12, 2014
Disable File Watchers on XP (For real this time)
This was referenced Aug 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request disabled file watching on XP. Here are the highlights: