This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
New file should fallback to the project root if the current file is outside the project #6561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is outside the project
ghost
assigned 
|
@RaymondLim can you review this fix for #6544? |
| @@ -338,8 +338,11 @@ define(function (require, exports, module) { | |||
| /** | |||
| * Returns true if absPath lies within the project, false otherwise. | |||
| * Does not support paths containing ".." | |||
| * @param {string|FileSystemEntry} absPath | |||
There was a problem hiding this comment.
Nit: param name should be absPathOrEntry.
|
Looks good. Just have one nit for JSDoc. Definitely better than my pull request since I was not aware of the existence of the function isWithinProject() and tried to use the project root node to get the desired result. |
|
Thanks @RaymondLim. Fix pushed. |
RaymondLim
added a commit
that referenced
this pull request
Jan 16, 2014
New file should fallback to the project root if the current file is outside the project
This was referenced Aug 30, 2021
This was referenced Sep 15, 2021
This was referenced May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force new files to be created in the current project if the selection is outside the project